feat(app): add include to RedirectOptions
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
👷 Deploy request for n3-supabase pending review.Visit the deploys page to approve it
|
jojomatik
force-pushed
the
feat/redirect-include
branch
from
037f804
to
ae5ad9c
Compare
jojomatik
changed the title
include to RedirectOptionsinclude to RedirectOptions
larbish
reviewed
Mar 6, 2024
src/runtime/plugins/auth-redirect.ts
Outdated
| const { cookieName, cookieOptions } = config | ||
|
|
||
| // Redirect only on included routes (if defined) | ||
| if (include && include.length > 0) { | ||
| const isIncluded = [...include].some((path) => { |
There was a problem hiding this comment.
Suggested change
| const isIncluded = [...include].some((path) => { | |
| const isIncluded = include.some((path) => { |
playground/pages/protected/index.vue
Outdated
There was a problem hiding this comment.
Can you create pages/protected.vue instead? (just to be consistent with the unprotected route)
jojomatik
force-pushed
the
feat/redirect-include
branch
from
ae5ad9c
to
726ba14
Compare
|
Thanks for the feedback. I've force pushed with the two changes :) |
larbish
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268
Types of changes
Description
Add an
includeoption toRedirectOptions. If set, only routes matching the supplied regex are considered for redirects.Checklist: