Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(kit, nuxt): always sort globby results #6029

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix(kit, nuxt): always sort globby results #6029

merged 1 commit into from
Jul 21, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Jul 21, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The order of the result from globby is not reliable. This will potentially cause the order of installed plugins/modules to be unstable across multiple builts or on different machines. We should always sort them to make it stable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 21, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 12cdb66
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62d91ee1feedb5000a7187af
😎 Deploy Preview https://deploy-preview-6029--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 changed the title fix: stable globby scan fix(kit, nuxt): always sort globby results Jul 21, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pi0 pi0 merged commit b4b9804 into main Jul 21, 2022
@pi0 pi0 deleted the fix/stable-globby branch July 21, 2022 10:46
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants