Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi, kit): enable esmResolve flag for jiti #6356

Merged
merged 1 commit into from
Aug 4, 2022
Merged

fix(nuxi, kit): enable esmResolve flag for jiti #6356

merged 1 commit into from
Aug 4, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 4, 2022

πŸ”— Linked issue

Related: #6340, unjs/unctx#23, unjs/unctx#25

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Some dependencies like estree-walker, are not only esm-only but only use exports.import field in package.json. This makes sure they are broken unless using esm native resolution!

We introduced an experimental flag few months ago for jiti to enable esm resolution and handle such package. It is already enabled for c12 and framework repo. This PR enabled it for kit utils as well.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 4, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 943db63
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62ebc21b341d1f0008bdc623

@pi0 pi0 changed the title fix(nuxi, kit): enable esmResolve flag for `jiti fix(nuxi, kit): enable esmResolve flag for jiti Aug 4, 2022
@pi0 pi0 merged commit e3534bc into main Aug 4, 2022
@pi0 pi0 deleted the fix/jiti-esm branch August 4, 2022 13:22
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants