Improve test performance #1953
Open
Improve test performance #1953
+106
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the TestDirectories class looking like a test class
…avid-2410-warnings
This reverts commit 366f4ff.
consolidate the test_kafka_source_commit and test_kafka_source_batch_pipe tests as they were nearly identical Improve test time from ~4min to 2:39
dagardner-nv
added
bug
mdemoret-nv
reviewed
Oct 17, 2024
|
|
||
| def parse_fn(resp: requests.Response) -> bool: | ||
| content = resp.content.decode('utf-8') | ||
| return 'OK' in content |
There was a problem hiding this comment.
Can we also check the status code? I would hate for it to return a 400 error with Im not OK and this test would pass
There was a problem hiding this comment.
It doesn't even call that method if the status code isn't 200:
if (resp.status_code == 200):
if parse_fn(resp):
return True…tions from 865 down to 145
… to all share a common milvus collection, cuts test time from 45s down to 26s
…avid-slow-tests-1948
…avid-slow-tests-1948
…avid-slow-tests-1948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wait_for_startedmethod which was causing an intermittent delay up to 40stest_kafka_source_commitandtest_kafka_source_batch_pipethese two tests were 80% similarnum_records=100parameter fromtest_kafka_source_batch_pipetest_http_server.py::test_simple_requestlowering the total number of test combinations from 865 down to 145.Closes #1948
By Submitting this PR I confirm: