Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Add early stop to autoencoder #2

Merged
8 commits merged into from
Jan 27, 2023
Merged

Add early stop to autoencoder #2

8 commits merged into from
Jan 27, 2023

Conversation

efajardo-nv
Copy link

add early stop
@efajardo-nv efajardo-nv changed the title Add early stop to autoencoder [REVIEW] Add early stop to autoencoder Oct 5, 2022
@efajardo-nv efajardo-nv changed the title [REVIEW] Add early stop to autoencoder Add early stop to autoencoder Oct 6, 2022
@efajardo-nv efajardo-nv marked this pull request as draft October 6, 2022 23:29
@efajardo-nv efajardo-nv marked this pull request as ready for review October 7, 2022 18:02
@mdemoret-nv mdemoret-nv changed the base branch from branch-22.09 to branch-22.11 November 16, 2022 02:50
Copy link

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small changes

dfencoder/autoencoder.py Outdated Show resolved Hide resolved
dfencoder/autoencoder.py Outdated Show resolved Hide resolved
@efajardo-nv
Copy link
Author

updates from feedback made. ready for re-review

@mdemoret-nv
Copy link

@efajardo-nv Can you resolve the merge conflicts and then we can merge?

Copy link

@gbatmaz gbatmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efajardo-nv efajardo-nv added feature request New feature or request non-breaking Non-breaking change labels Jan 25, 2023
@efajardo-nv efajardo-nv changed the base branch from branch-22.11 to branch-23.01 January 25, 2023 16:26
@efajardo-nv efajardo-nv requested a review from a team January 25, 2023 16:26
@efajardo-nv efajardo-nv marked this pull request as draft January 25, 2023 16:53
@efajardo-nv efajardo-nv marked this pull request as ready for review January 26, 2023 04:42
Copy link

@gbatmaz gbatmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link

/merge

@ghost ghost merged commit ec21ab6 into branch-23.01 Jan 27, 2023
dagardner-nv pushed a commit that referenced this pull request Jan 31, 2023
dagardner-nv pushed a commit that referenced this pull request Jan 31, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants