feat: allow arguments for :Neorg generate-workspace-summary
#1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method can be used to add custom metadata into file instead of defaults. If table is empty of nil then simply uses default like inject_metadata
No longer uses tabnew and relies on buffer 0 to insert metadata into the newly created file.
Added class annotations to better describe the input options for create_file and create_metadata.
spaces instead of tabs
Updated naming of @Class annotations to better align with the naming used in the rest of the project.
Dirman now broadcasts an event on file creation that metagen listen to. Metagen then injects desired metadata if present.
Neorg generate-workspace-summary now takes possible arguments. Each argument is space separated as a distinct category. Also made a method public to call it from lua instead of a vim command.
1 task
|
This looks good to me! Could you also add a small explanation to the comment at the top of the file explaining what the arguments to the |
Added documentation explaining how arguments work with the command `Neorg generate-workspace-summary`.
|
Sounds great. I've added a line or two explaining how to use arguments for the command. |
|
Not sure I understand why the build failed. I don't see any logs related to the summary module. :/ Do I need to revert my merge commit from |
Perfect, thank you for the PR! :) |
vhyrro
changed the title
:Neorg generate-workspace-summary
benlubas
pushed a commit
to benlubas/neorg
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1086
Changes
This pull request changes the generate-workspace-summary in two ways:
Neorg generate-workspace-summarycommand now takes optional arguments.generate_workspace_summarysuch that it can be called through lua directly if needed.Needs feedback
The way it is implemented in this pull request accomplishes the goal by separating the arguments by space for separate categories, meaning you cannot target a category containing spaces with the neorgcmd.
I am not sure what is the better implementation - this or one where the Neorgcmd merges all inputs into a single category.