Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journal TOC generates wrong paths on Windows #830

Closed
2 tasks done
SteveWolligandt opened this issue May 2, 2023 · 2 comments
Closed
2 tasks done

Journal TOC generates wrong paths on Windows #830

SteveWolligandt opened this issue May 2, 2023 · 2 comments
Labels
bug Issues related to bugs. Please attach a severity, a priority and category with this label.

Comments

@SteveWolligandt
Copy link

SteveWolligandt commented May 2, 2023

Prerequisites

  • I am using the latest stable release of Neovim
  • I am using the latest version of the plugin

Neovim Version

NVIM v0.9.0-dev-857+g2c5906b55

Neorg setup

require('neorg').setup {
load = {
   ["core.defaults"] = {},
   ["core.autocommands"] = {},
   ["core.export"] = {config={}},
   ["core.export.markdown"] = {config={}},
   ["core.integrations.treesitter"] = {config={}},
   -- ["core.completion"] = {config = {engine="nvim-cmp"}},
   ["core.dirman"] = {
     config = {
       workspaces = {
         notes = "~/notes",
       },
       default_workspace='notes'
     }
   },
   ["core.qol.todo_items"] = {config = {}},
   ["core.esupports.hop"] = {config = {}},
   ["core.concealer"] = {config={}},["core.keybinds"] = {
     config = {}
   },
   ["core.presenter"] = {
     config = { zen_mode = "zen-mode" }
   }
 }
}
}

Actual behavior

When doing :Neorg journal today a file ~\notes\journal\2023\05\02.norg is being created.

When doing :Neorg journal toc update it generates a file like this:

* 2023
** May
{:$\journal\2023\05\01:}[01]
{:$\journal\2023\05\02:}[02]

Unfortunately when I open one of the links it opens the file ~\notes\journal\$\journal\2023\05\02.norg

Expected behavior

Neorg's TOC of the journal should create correct links to individual journals

Steps to reproduce

:Neorg journal today
:Neorg journal toc update
:Neorg journal toc open

Potentially conflicting plugins

No response

Other information

No response

Help

No

Implementation help

No response

@SteveWolligandt SteveWolligandt added the bug Issues related to bugs. Please attach a severity, a priority and category with this label. label May 2, 2023
vhyrro added a commit that referenced this issue May 2, 2023
@vhyrro
Copy link
Member

vhyrro commented May 2, 2023

Hey, this should be fixed now! It wasn't a bug in the journal per se, but rather in the function that handles expanding the $ to your desired workspace name.

If it works then feel free to close the issue :)

@SteveWolligandt
Copy link
Author

Works, awesome! Thanks for the quick help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues related to bugs. Please attach a severity, a priority and category with this label.
Projects
None yet
Development

No branches or pull requests

2 participants