Rename some files to be more cross platform

nvm-sh · Jan 3, 2021 · 8dad2ee · 8dad2ee
1 parent 4e9df33
commit 8dad2ee
Show file tree

Hide file tree

Showing 69 changed files with 61 additions and 2 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -12,10 +12,10 @@ trim_trailing_whitespace = true
 [*.txt]
 indent_size = false
 
-[test/fast/Listing versions/Running "nvm ls" calls into nvm_alias]
+[test/fast/Listing versions/Running 'nvm ls' calls into nvm_alias]
 indent_size = false
 
-[test/fast/Listing versions/Running "nvm ls --no-alias" does not call into nvm_alias]
+[test/fast/Listing versions/Running 'nvm ls --no-alias' does not call into nvm_alias]
 indent_size = false
 
 [test/fast/Unit tests/mocks/**]

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -36,3 +36,10 @@ jobs:
  cp README.md README.md.orig
  npm run doctoc
  diff -q README.md README.md.orig
+
+ test_naming:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: check tests filenames
+ run: ./rename_test.sh --check
diff --git a/rename_test.sh b/rename_test.sh
@@ -0,0 +1,52 @@
+#! /usr/bin/env bash
+
+find_name(){
+ find test -name "*[\\/:\*\?\"<>\|]*" -o -name "*."
+}
+
+check_name() {
+ if [ "$(find_name | wc -l)" != "0" ]; then
+ printf '%s\n\n' "The following filenames contain unwanted characters:"
+ find_name
+ printf '\n%s\n%s\n' "Please run ./rename_test.sh" "If the problem persist, please open an issue."
+ exit 1
+ else
+ echo "Ok"
+ fi
+}
+
+rename_test() {
+ local filename
+ local new_filename
+ while read -r filename; do
+ # Even though it looks < and > are replaced by the same < and >, the latters are not ASCII code
+ # If you check with 'cat -v rename_test.sh' you would see 's/</M-KM-^B/g' and 's/>/M-KM-^C/g'
+ # M-KM-^B -> U+02C2
+ # M-KM-^C -> U+02C3
+ new_filename=$(echo "$filename" | sed -r \
+ -e "s/\"/'/g" \
+ -e 's/</˂/g' \
+ -e 's/>/˃/g' \
+ -e 's/^(.*)\.$/\1/'
+ )
+ printf '%s\n%s\n\n' "$filename" "$new_filename"
+ [ "$filename" != "$new_filename" ] && git mv "$filename" "$new_filename"
+ done < <(find_name)
+
+ if [ "$(find_name | wc -l)" != "0" ]; then
+ echo "Still some files to treat:"
+ find_name
+ else
+ echo "Done"
+ fi
+}
+
+main() {
+ if [ "$1" = "--check" ]; then
+ check_name
+ else
+ rename_test
+ fi
+}
+
+main "$@"
diff --git a/...s" should not accept aliases with slashes → ...s' should not accept aliases with slashes b/...s" should not accept aliases with slashes → ...s' should not accept aliases with slashes
diff --git a/...aliases when they shadow a built-in alias → ...aliases when they shadow a built-in alias b/...aliases when they shadow a built-in alias → ...aliases when they shadow a built-in alias
diff --git a/...liases with names equal to built-in alias → ...liases with names equal to built-in alias b/...liases with names equal to built-in alias → ...liases with names equal to built-in alias
diff --git a/...s" should not accept aliases with slashes → ...s' should not accept aliases with slashes b/...s" should not accept aliases with slashes → ...s' should not accept aliases with slashes
diff --git a/... <target>" again should change the target → ... ˂target˃' again should change the target b/... <target>" again should change the target → ... ˂target˃' again should change the target
diff --git a/...s <aliasname>" should list but one alias. → ...as ˂aliasname˃' should list but one alias b/...s <aliasname>" should list but one alias. → ...as ˂aliasname˃' should list but one alias
diff --git a/...s implicit aliases when they do not exist → ...s implicit aliases when they do not exist b/...s implicit aliases when they do not exist → ...s implicit aliases when they do not exist
diff --git a/... instead of implicit aliases when present → ... instead of implicit aliases when present b/... instead of implicit aliases when present → ... instead of implicit aliases when present
diff --git a/...ning "nvm alias" should list all aliases. → ...nning 'nvm alias' should list all aliases b/...ning "nvm alias" should list all aliases. → ...nning 'nvm alias' should list all aliases
diff --git a/...alias" should ensure LTS alias dir exists → ...alias' should ensure LTS alias dir exists b/...alias" should ensure LTS alias dir exists → ...alias' should ensure LTS alias dir exists
diff --git a/...0.0.2" should display only version 0.0.2. → ... 0.0.2' should display only version 0.0.2 b/...0.0.2" should display only version 0.0.2. → ... 0.0.2' should display only version 0.0.2
diff --git a/...return a nonzero exit code when not found → ...return a nonzero exit code when not found b/...return a nonzero exit code when not found → ...return a nonzero exit code when not found
diff --git a/... --no-alias" does not call into nvm_alias → ... --no-alias' does not call into nvm_alias b/... --no-alias" does not call into nvm_alias → ... --no-alias' does not call into nvm_alias
diff --git a/..."nvm ls --no-alias" with a pattern errors → ...'nvm ls --no-alias' with a pattern errors b/..."nvm ls --no-alias" with a pattern errors → ...'nvm ls --no-alias' with a pattern errors
diff --git a/...0.0.2" should display only version 0.0.2. → ... 0.0.2' should display only version 0.0.2 b/...0.0.2" should display only version 0.0.2. → ... 0.0.2' should display only version 0.0.2
diff --git a/... 0.2" should display only 0.2.x versions. → ...s 0.2' should display only 0.2.x versions b/... 0.2" should display only 0.2.x versions. → ...s 0.2' should display only 0.2.x versions
diff --git a/...return a nonzero exit code when not found → ...return a nonzero exit code when not found b/...return a nonzero exit code when not found → ...return a nonzero exit code when not found
diff --git a/...ions/Running "nvm ls io" should return NA → ...ions/Running 'nvm ls io' should return NA b/...ions/Running "nvm ls io" should return NA → ...ions/Running 'nvm ls io' should return NA
diff --git a/...return a nonzero exit code when not found → ...return a nonzero exit code when not found b/...return a nonzero exit code when not found → ...return a nonzero exit code when not found
diff --git a/...uld return the appropriate implicit alias → ...uld return the appropriate implicit alias b/...uld return the appropriate implicit alias → ...uld return the appropriate implicit alias
diff --git a/... should include "system" when appropriate → ... should include 'system' when appropriate b/... should include "system" when appropriate → ... should include 'system' when appropriate
diff --git a/...ons/Running "nvm ls" calls into nvm_alias → ...ons/Running 'nvm ls' calls into nvm_alias b/...ons/Running "nvm ls" calls into nvm_alias → ...ons/Running 'nvm ls' calls into nvm_alias
diff --git a/...s" should display all installed versions. → ...ls' should display all installed versions b/...s" should display all installed versions. → ...ls' should display all installed versions
diff --git a/...Running "nvm ls" should filter out ".nvm" → ...Running 'nvm ls' should filter out '.nvm' b/...Running "nvm ls" should filter out ".nvm" → ...Running 'nvm ls' should filter out '.nvm'
diff --git a/...ing "nvm ls" should filter out "versions" → ...ing 'nvm ls' should filter out 'versions' b/...ing "nvm ls" should filter out "versions" → ...ing 'nvm ls' should filter out 'versions'
diff --git a/... should include "system" when appropriate → ... should include 'system' when appropriate b/... should include "system" when appropriate → ... should include 'system' when appropriate
diff --git a/...list versions in the "versions" directory → ...list versions in the 'versions' directory b/...list versions in the "versions" directory → ...list versions in the 'versions' directory
diff --git a/..."nvm ls" should not show a trailing slash → ...'nvm ls' should not show a trailing slash b/..."nvm ls" should not show a trailing slash → ...'nvm ls' should not show a trailing slash
diff --git a/...vx.x.x should only list a matched version → ...vx.x.x should only list a matched version b/...vx.x.x should only list a matched version → ...vx.x.x should only list a matched version
diff --git a/...ng "nvm ls" with nounset should not fail. → ...ing 'nvm ls' with nounset should not fail b/...ng "nvm ls" with nounset should not fail. → ...ing 'nvm ls' with nounset should not fail
diff --git a/...uld create a file in the alias directory. → ...ould create a file in the alias directory b/...uld create a file in the alias directory. → ...ould create a file in the alias directory
diff --git a/..." should display current nvm environment. → ...t' should display current nvm environment b/..." should display current nvm environment. → ...t' should display current nvm environment
diff --git a/...ould unset the nvm environment variables. → ...hould unset the nvm environment variables b/...ould unset the nvm environment variables. → ...hould unset the nvm environment variables
diff --git a/...l-packages-from" requires a valid version → ...l-packages-from' requires a valid version b/...l-packages-from" requires a valid version → ...l-packages-from' requires a valid version
diff --git a/...all" with an invalid version fails nicely → ...all' with an invalid version fails nicely b/...all" with an invalid version fails nicely → ...all' with an invalid version fails nicely
diff --git a/...vm unalias" should remove the alias file. → ...nvm unalias' should remove the alias file b/...vm unalias" should remove the alias file. → ...nvm unalias' should remove the alias file
diff --git a/... should remove the appropriate directory. → ...' should remove the appropriate directory b/... should remove the appropriate directory. → ...' should remove the appropriate directory
diff --git a/...h incorrect file permissions fails nicely → ...h incorrect file permissions fails nicely b/...h incorrect file permissions fails nicely → ...h incorrect file permissions fails nicely
diff --git a/... should unset all function and variables. → ...' should unset all function and variables b/... should unset all function and variables. → ...' should unset all function and variables
diff --git a/...m use foo" where "foo" is circular aborts → ...m use foo' where 'foo' is circular aborts b/...m use foo" where "foo" is circular aborts → ...m use foo' where 'foo' is circular aborts
diff --git a/... "nvm use iojs" uses latest io.js version → ... 'nvm use iojs' uses latest io.js version b/... "nvm use iojs" uses latest io.js version → ... 'nvm use iojs' uses latest io.js version
diff --git a/... "nvm use system" should work as expected → ... 'nvm use system' should work as expected b/... "nvm use system" should work as expected → ... 'nvm use system' should work as expected
diff --git a/...d create and change the "current" symlink → ...d create and change the 'current' symlink b/...d create and change the "current" symlink → ...d create and change the 'current' symlink
diff --git a/... symlink if $NVM_SYMLINK_CURRENT is false → ... symlink if $NVM_SYMLINK_CURRENT is false b/... symlink if $NVM_SYMLINK_CURRENT is false → ... symlink if $NVM_SYMLINK_CURRENT is false
diff --git a/...m use" should drop CR char automatically. → ...vm use' should drop CR char automatically b/...m use" should drop CR char automatically. → ...vm use' should drop CR char automatically
diff --git a/...sh should make the nvm command available. → ....sh should make the nvm command available b/...sh should make the nvm command available. → ....sh should make the nvm command available
diff --git a/..." should display current nvm environment. → ...t' should display current nvm environment b/..." should display current nvm environment. → ...t' should display current nvm environment
diff --git a/...Preamble works and respects "silent" flag → ...Preamble works and respects 'silent' flag b/...Preamble works and respects "silent" flag → ...Preamble works and respects 'silent' flag
diff --git a/...exec/Running "nvm exec --lts" should work → ...exec/Running 'nvm exec --lts' should work b/...exec/Running "nvm exec --lts" should work → ...exec/Running 'nvm exec --lts' should work
diff --git a/...m exec/Running "nvm exec 0.x" should work → ...m exec/Running 'nvm exec 0.x' should work b/...m exec/Running "nvm exec 0.x" should work → ...m exec/Running 'nvm exec 0.x' should work
diff --git a/... "nvm exec" should pick up .nvmrc version → ... 'nvm exec' should pick up .nvmrc version b/... "nvm exec" should pick up .nvmrc version → ... 'nvm exec' should pick up .nvmrc version
diff --git a/...kages $(nvm ls current)" should error out → ...kages $(nvm ls current)' should error out b/...kages $(nvm ls current)" should error out → ...kages $(nvm ls current)' should error out
diff --git a/..."nvm run --harmony --version" should work → ...'nvm run --harmony --version' should work b/..."nvm run --harmony --version" should work → ...'nvm run --harmony --version' should work
diff --git a/...m run/Running "nvm run --lts" should work → ...m run/Running 'nvm run --lts' should work b/...m run/Running "nvm run --lts" should work → ...m run/Running 'nvm run --lts' should work
diff --git a/...or out sensibly when 0.x is not installed → ...or out sensibly when 0.x is not installed b/...or out sensibly when 0.x is not installed → ...or out sensibly when 0.x is not installed
diff --git a/...nvm run/Running "nvm run 0.x" should work → ...nvm run/Running 'nvm run 0.x' should work b/...nvm run/Running "nvm run 0.x" should work → ...nvm run/Running 'nvm run 0.x' should work
diff --git a/...g "nvm run" should pick up .nvmrc version → ...g 'nvm run' should pick up .nvmrc version b/...g "nvm run" should pick up .nvmrc version → ...g 'nvm run' should pick up .nvmrc version
diff --git a/..."nvm uninstall 0.12.6" uninstalls v0.12.6 → ...'nvm uninstall 0.12.6' uninstalls v0.12.6 b/..."nvm uninstall 0.12.6" uninstalls v0.12.6 → ...'nvm uninstall 0.12.6' uninstalls v0.12.6
diff --git a/...h incorrect file permissions fails nicely → ...h incorrect file permissions fails nicely b/...h incorrect file permissions fails nicely → ...h incorrect file permissions fails nicely
diff --git a/...g "nvm use --lts" uses latest LTS version → ...g 'nvm use --lts' uses latest LTS version b/...g "nvm use --lts" uses latest LTS version → ...g 'nvm use --lts' uses latest LTS version
diff --git a/... --lts=foo" uses latest "foo" LTS version → ... --lts=foo' uses latest 'foo' LTS version b/... --lts=foo" uses latest "foo" LTS version → ... --lts=foo' uses latest 'foo' LTS version
diff --git a/... "nvm use iojs" uses latest io.js version → ... 'nvm use iojs' uses latest io.js version b/... "nvm use iojs" uses latest io.js version → ... 'nvm use iojs' uses latest io.js version
diff --git a/...use node --silent" doesn't print anything → ...use node --silent' doesn't print anything b/...use node --silent" doesn't print anything → ...use node --silent' doesn't print anything
diff --git a/...use node" uses latest stable node version → ...use node' uses latest stable node version b/...use node" uses latest stable node version → ...use node' uses latest stable node version
diff --git a/...use v1.0.0" uses iojs-v1.0.0 iojs version → ...use v1.0.0' uses iojs-v1.0.0 iojs version b/...use v1.0.0" uses iojs-v1.0.0 iojs version → ...use v1.0.0' uses iojs-v1.0.0 iojs version
diff --git a/...nning "nvm use" calls "nvm_die_on_prefix" → ...nning 'nvm use' calls 'nvm_die_on_prefix' b/...nning "nvm use" calls "nvm_die_on_prefix" → ...nning 'nvm use' calls 'nvm_die_on_prefix'