Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] update cdnvm implementation #2442

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[readme] update cdnvm implementation #2442

merged 1 commit into from
Feb 19, 2021

Conversation

lzwcyd
Copy link

@lzwcyd lzwcyd commented Feb 19, 2021

当函数名为find-up时,定时运行会报以下错误:

`find-up': not a valid identifier

修改为find_up即可修复该问题

@lzwcyd
Copy link
Author

lzwcyd commented Feb 19, 2021

当我们的项目在flow上自动部署的时候,会显示该错误

`find-up': not a valid identifier

修改为find_up即可解决

@ljharb
Copy link
Member

ljharb commented Feb 19, 2021

I don't know what "flow" is - what exactly is reporting this as an invalid identifier?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lzwcyd
Copy link
Author

lzwcyd commented Feb 19, 2021

我不知道什么是“流”-究竟是什么将其报告为无效标识符?

我不知道什么是“流”-究竟是什么将其报告为无效标识符?

可能是我的描述存在问题,当我的项目在部署的时候出现这个错误:

[2021-02-19 20:41:06][
/root/.bashrc: line 24: `find-up': not a valid identifier
]

README.md Outdated
Comment on lines 506 to 509
nvm_find_up() {
path=$(pwd)
while [[ "$path" != "" && ! -e "$path/$1" ]]; do
path=${path%/*}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm itself already defines nvm_find_up, so this entire function can be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我已经将find_up移除了

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am an ordinary Chinese student, and I am glad to receive your reply.This will make me love this industry even more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the contribution, and being willing to deal with translations :-)

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb changed the title doc: update [readme] update cdnvm implementation Feb 19, 2021
@ljharb ljharb merged commit d9b11ba into nvm-sh:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants