Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--fix for indentation adds CRLF line-endings to all files it touches #63

Closed
unitysipu opened this issue Jul 2, 2020 · 5 comments · Fixed by #65
Closed

--fix for indentation adds CRLF line-endings to all files it touches #63

unitysipu opened this issue Jul 2, 2020 · 5 comments · Fixed by #65

Comments

@unitysipu
Copy link

I'm working primarily on linux and i've noticed when running --fix for indentation every file has LF line-endings turned to CRLF. The tool shouldn't mess with the file formatting this way.
@davegallant
Copy link
Contributor

davegallant commented Jul 7, 2020 •
edited
Loading

I wrote a wrapper/workaround which encapsulates the dependencies in a docker container and includes dos2unix with an example:
https:/davegallant/docker-groovy-lint

@aristotll
Copy link

similar problem

@nvuillam
Copy link
Owner

nvuillam commented Jul 7, 2020

If i join the lines with os.EOL, will it be ok for you ?

https://nodejs.org/api/os.html#os_os_eol

@aristotll
Copy link

If i join the lines with os.EOL, will it be ok for you ?

https://nodejs.org/api/os.html#os_os_eol

I think it will be ok

@nvuillam nvuillam mentioned this issue Jul 8, 2020
Merged
nvuillam added a commit that referenced this issue Jul 9, 2020
@nvuillam
Use os.EOL (#65)
e5b99b8 
- Use os.EOL (#65) solving (#63) --fix for indentation adds CRLF line-endings to all files it touches

Closes #63
@nvuillam
Copy link
Owner

@unitysipu @davegallant @aristotll : published in latest patch, please reopen if there is still an issue :)

Note: not propagated to VsCode Groovy Lint yet

nvuillam added a commit to nvuillam/vscode-groovy-lint that referenced this issue Jul 12, 2020
@nvuillam
Override java VM & EOL fix
9cbc519 
- New settings **groovyLint.java.executable** and **groovyLint.java.options**
- Upgrade to [npm-groovy-lint](https://www.npmjs.com/package/npm-groovy-lint) v5.5.0
  - Allow to override java executable and options [(#54)](#54)
  - Use os.EOL [(#65)](nvuillam/npm-groovy-lint#65) solving  [(#63)](nvuillam/npm-groovy-lint#63) --fix for indentation adds CRLF line-endings to all files it touches
@nvuillam nvuillam mentioned this issue Jul 12, 2020
Merged
nvuillam added a commit to nvuillam/vscode-groovy-lint that referenced this issue Jul 12, 2020
@nvuillam
Override java VM & EOL fix (#63)
596d57f 
- New settings **groovyLint.java.executable** and **groovyLint.java.options**
- Upgrade to [npm-groovy-lint](https://www.npmjs.com/package/npm-groovy-lint) v5.5.0
  - Allow to override java executable and options [(#54)](#54)
  - Use os.EOL [(#65)](nvuillam/npm-groovy-lint#65) solving  [(#63)](nvuillam/npm-groovy-lint#63) --fix for indentation adds CRLF line-endings to all files it touches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use os.EOL nvuillam/npm-groovy-lint
4 participants
@davegallant @aristotll @nvuillam @unitysipu