[win] removed exported zlib symbols #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run nw as node decouple node dll add g_dom_context
fixup! chromium-integration fixup! new mac loop
Or we'll have loop in the list when the async req is inserted again by uv_async_send_nw Fix nwjs/nw.js#2332
src\third_party\node\src\node_revert.cc(15) : warning C4065: switch statement contains 'default' but no 'case' labels
revert f1488bb
Strings in DOM may be converted to two bytes representation, which should be processed as array of `uint16_t` when decoding hex or base64. base64 decoding in Node.js can fallback to a slow implementation to skip invalid characters (i.e. `\0` in this case). This patch can also keep base64 decoding running under the fast implementation. fixed nwjs/nw.js#5069
zlib symbols was exported in c843e58 with zlib 1.2.8. Node.js in NW was built with chromium zlib 1.2.5 + google's patches, which didn't exported those symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
zlib symbols was exported in c843e58 with zlib 1.2.8. Node.js in NW
was built with chromium zlib 1.2.5 + google's patches, which didn't
exported those symbols.