Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of nodewebkit is used but how can i add document sharing extentions? #3068

Closed
shamun opened this issue Feb 9, 2015 · 11 comments

Comments

@shamun
Copy link

shamun commented Feb 9, 2015

With Canary, Chrome we have stable screen sharing extension which is working.

Now i am using NW latest version: http://dl.nwjs.io/live-build/02-08-2015/c91494c-4aad9fe-dc10e62-add523e-40ccb71-c114bb7/

But How can i use the extensions with NW or make it compatible with NW?

@iwege
Copy link

iwege commented Feb 10, 2015

I have done this before in nw 0.11 . You can add "chromium-args" : "--enable-usermedia-screen-capturing" in your package.json to enable the screen capturing API.

https:/iwege/getScreenMedia

@shamun
Copy link
Author

shamun commented Feb 10, 2015

@iwege: I will test myself and update this follow up later.

I need to make this compatible with NodeWebkit, have you used this one from Henrik? e.g: https:/HenrikJoreteg/getScreenMedia/tree/master/chrome-extension-sample

@iwege
Copy link

iwege commented Feb 10, 2015

@shamun
I changed this library, see this commit : iwege/getScreenMedia@c9c47c6

And I wrote a sample for node-webkit:
https:/iwege/getScreenMedia/tree/master/node-webkit-sample

@shamun
Copy link
Author

shamun commented Feb 10, 2015

@iwege: i just used it with nodewebkit 12(alpha) and working. But please note following:

  • Quality of capture is slow
  • Quality of screen capture is not crisp and clear

Compared to Canary, Google Chrome Stable the speed and quality is much better. Why is it not similar with nodewebkit and your solution, any idea please?

@iwege
Copy link

iwege commented Feb 10, 2015

@shamun
Maybe you can change those options:https:/iwege/getScreenMedia/blob/c9c47c6fe1e4ef4ab36927e1226068adf92ea6d5/getscreenmedia.bundle.js#L35

But I don't know how to change the quality of screen capture. Changing the video size to the window size is a good solution for me.
https:/iwege/getScreenMedia/blob/master/node-webkit-sample/index.html#L18

@shamun
Copy link
Author

shamun commented Feb 10, 2015

@iwege: i will close this issue as its fixed. And open issue in your issue repository for the quality follow up (Which is other topic)

Thank you for your support, appreciate it, i will play with your suggestion i think it has to do with the tuning of resolutions and framerate somewhere.

@shamun shamun closed this as completed Feb 10, 2015
@shamun
Copy link
Author

shamun commented Feb 10, 2015

@iwege: you do not have issue tracker there. I wanted to inform you that. In Google Chrome/Canary when i click screen share i get a small popup to select : screen1 or screen2 or running applications.

With your solution how can i have that selection dialog window please?

@iwege
Copy link

iwege commented Feb 10, 2015

@shamun I don't find any solution for it. Maybe you need to follow those issues: #576

@shamun
Copy link
Author

shamun commented Feb 10, 2015

OK

@shamun
Copy link
Author

shamun commented Feb 19, 2015

@iwege: do you know any updates on this issue yet? #3077

@iwege
Copy link

iwege commented Feb 20, 2015

@shamun sorry, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants