Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lighter linker for windows build #928

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use lighter linker for windows build #928

wants to merge 2 commits into from

Conversation

neacsu
Copy link
Collaborator

@neacsu neacsu commented Aug 19, 2024 •
edited by mmsinclair
Loading

This change is Reviewable

@neacsu neacsu requested a review from octol August 19, 2024 11:42
octol
octol approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@octol octol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and links when I tested locally

@pronebird
Copy link
Contributor

What's the impact of this change?

@neacsu
Copy link
Collaborator Author

neacsu commented Aug 30, 2024

What's the impact of this change?

CI rust builds on windows run into OOM, when the ci machine has been run for a longer time. This linker is supposed to use less memory, but in order to reproduce it, we need the machine to start OOMing again and see if this PR fixes that.
PS: We already tried bumping up the RAM on the windows machine to 32GB, put that still isn't enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octol octol octol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neacsu @pronebird @octol