Expose some types and gadgets #1860
Conversation
There was a problem hiding this comment.
some unused imports and an unused method purged here
There was a problem hiding this comment.
exposing the uint32 / bytes converters that we already use internally for sha2
| function sha256Compression(H: UInt32[], W: UInt32[]) { | ||
| function sha256Compression([...H]: UInt32[], W: UInt32[]) { |
There was a problem hiding this comment.
this fixes a bug, the compression function mutated its input, which bit me because in dynamic sha2 you don't necessarily want to use the output
| function mapValue< | ||
| A extends ProvableHashable<any>, | ||
| V extends InferValue<A>, | ||
| W, | ||
| T extends InferProvable<A> | ||
| >( |
There was a problem hiding this comment.
method to take one provable and modify its "value" type
|
|
||
| // expore base class so that we can detect Bytes with `instanceof` | ||
| Bytes.Base = InternalBytes; |
There was a problem hiding this comment.
we should always expose base classes somewhere for type factories, so that users can detect what class they have using instanceof.
putting base classes on .Base of the factory function seems like a nice, non-intrusive pattern to me.
Several additions that were handy when implementing dynamic-length SHA2 and general-purpose array types in zksecurity/mina-attestations#25
InferValue,From,TupleNarrayGet()and UInt32 to/from bytesPackedclass much better typedCI run here: zksecurity#2