Defer importing polyfills (esp. node-fetch)

typescript/package.json

@@ -21,7 +21,7 @@
  "lint": "yarn lint:tsclient && yarn lint:examples",
  "lint:tsclient": "xo --ignores ./examples && prettier --check {tsconfig,package}.json",
  "lint:examples": "xo ./examples && tools/update-examples-parcel-version.sh --check",
- "test:unit": "jest --projects test/jest/unit/",
+ "test:unit": "node --experimental-vm-modules node_modules/.bin/jest --projects test/jest/unit/",
  "test:examples": "jest --projects test/examples/",
  "test:integration:nodejs": "node test/pure-nodejs.js",
  "test:integration:jest": "jest --projects test/jest/integration/",
@@ -78,7 +78,7 @@
  "form-data": "^4.0.0",
  "jsrsasign": "^10.3.0",
  "ky": "^0.28.5",
- "node-fetch": "3.0.0-beta.9",
+ "ky-universal": "^0.9.1",
  "param-case": "^3.0.3",
  "type-fest": "^1.3.0",
  "web-streams-polyfill": "^3.1.0"

typescript/src/asset.ts

@@ -25,7 +25,7 @@ export namespace AssetImpl {
  client: HttpClient,
  params?: EscrowedAssetSearchParams & PageParams,
  ): Promise<Page<EscrowedAsset>> {
- return client.search<EscrowedAsset>(`${ASSETS_EP}/search`, params);
+ return client.search<EscrowedAsset>(`${ASSETS_EP}`, params);
  }
 
  export async function get(client: HttpClient, assetId: AssetId): Promise<EscrowedAsset> {

typescript/src/document.ts

@@ -1,5 +1,6 @@
 import type { ReadStream } from 'fs';
 
+import AbortController from 'abort-controller';
 import EventEmitter from 'eventemitter3';
 import FormData from 'form-data';
 import type { Readable } from 'readable-stream';

typescript/src/http.ts

@@ -10,7 +10,6 @@ import { paramCase } from 'param-case';
 import type { PODDocument } from './document';
 import type { JsonSerializable, Page } from './model.js';
 import type { TokenProvider } from './token.js';
-import { pipeToPolyfill } from './polyfill.js';
 
 const DEFAULT_API_URL =
  globalThis?.process?.env?.PARCEL_API_URL ?? 'https://api.oasislabs.com/parcel/v1';
@@ -329,6 +328,7 @@ export class Download implements AsyncIterable<Uint8Array> {
  }
 
  // Firefox's native ReadableStream is missing pipeTo.
+ const pipeToPolyfill = (await import('./polyfill.js')).pipeToPolyfill;
  return pipeToPolyfill(body, sink);
  }
 

typescript/src/polyfill.ts

@@ -7,21 +7,8 @@ import {
  createReadableStreamWrapper,
  createWritableStreamWrapper,
 } from '@mattiasbuelens/web-streams-adapter';
-import AbortController from 'abort-controller';
-import FormData from 'form-data';
-import fetch, { Headers, Request as RequestPF, Response as ResponsePF } from 'node-fetch';
 import * as webStreams from 'web-streams-polyfill/dist/ponyfill.es2018.js';
 
-globalThis.fetch =
- globalThis.fetch ??
- (async (url: any, options) => fetch(url, { highWaterMark: 1e7 /* 10 MB */, ...options } as any));
-globalThis.Headers = globalThis.Headers ?? Headers;
-globalThis.Request = globalThis.Request ?? RequestPF;
-globalThis.Response = globalThis.Response ?? ResponsePF;
-globalThis.AbortController = globalThis.AbortController ?? AbortController;
-globalThis.FormData = globalThis.FormData ?? FormData;
-globalThis.ReadableStream = globalThis.ReadableStream ?? webStreams.ReadableStream;
-globalThis.WritableStream = globalThis.WritableStream ?? webStreams.WritableStream;
 const toReadableStreamPF = createReadableStreamWrapper(webStreams.ReadableStream) as unknown as (
  r: globalThis.ReadableStream,
 ) => webStreams.ReadableStream;

typescript/src/token.ts

@@ -5,7 +5,8 @@ import type { JsonObject, Merge } from 'type-fest';
 
 import { appendAsLastBeforeRequest, dontCloneForAfterResponses } from './http.js';
 import type { IdentityId } from './identity.js';
-import './polyfill.js'; // eslint-disable-line import/no-unassigned-import
+// @ts-ignore
+if (!globalThis.fetch) import('./polyfill.js'); // eslint-disable-line import/no-unassigned-import
 
 export class TokenError extends HTTPError {
  name = 'TokenError';

typescript/test/jest.config.js

@@ -17,7 +17,17 @@ const config = {
  '\\.ts$': 'ts-jest',
  '\\.js$': 'babel-jest',
  },
- transformIgnorePatterns: ['<rootDir>/node_modules/?!(ky|node-fetch)'],
+ transformIgnorePatterns: ['<rootDir>/node_modules/?!(node-fetch)'],
+
+ // cf. https://kulshekhar.github.io/ts-jest/docs/guides/esm-support/
+ extensionsToTreatAsEsm: ['.ts'],
+ globals: {
+ 'ts-jest': {
+ useESM: true,
+ },
+ },
+ // cf. https:/sindresorhus/ky-universal/issues/35
+ setupFiles: ["./test/jest.setup.js"],
 };
 
 export default config;

typescript/test/jest.setup.js

@@ -0,0 +1,8 @@
+// cf. https:/sindresorhus/ky-universal/issues/35
+
+import fetch from 'node-fetch';
+
+globalThis.fetch = fetch;
+globalThis.Request = fetch.Request;
+globalThis.Response = fetch.Response;
+globalThis.Headers = fetch.Headers;

typescript/test/jest/unit/token.spec.ts

@@ -1,6 +1,7 @@
 import jwt from 'jsonwebtoken';
 import { KEYUTIL } from 'jsrsasign';
 import nock from 'nock';
+import ky from 'ky-universal';
 
 import {
  PARCEL_RUNTIME_AUD,