Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure only specific crates are included in Rust coverage #1174

Merged
merged 2 commits into from
Nov 12, 2018

Conversation

kostko
Copy link
Member

@kostko kostko commented Nov 12, 2018

Fixes #1137

@kostko
Copy link
Member Author

kostko commented Nov 12, 2018

I've cherry-picked the "Fix linking to untrusted libraries from Intel SGX SDK" commit from #1159 as this is also required here.

@kostko kostko force-pushed the kostko/feature/rust-coverage branch from 864ce28 to 70f2536 Compare November 12, 2018 14:42
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #1174 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   56.42%   56.49%   +0.06%     
==========================================
  Files         121      121              
  Lines        9155     9155              
==========================================
+ Hits         5166     5172       +6     
+ Misses       3460     3456       -4     
+ Partials      529      527       -2
Impacted Files Coverage Δ
go/roothash/tests/tester.go 94.16% <0%> (+1.45%) ⬆️
go/scheduler/alg/greedy_subgraphs_scheduler.go 89.47% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b8fa4f...70f2536. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #1174 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   56.42%   56.48%   +0.05%     
==========================================
  Files         121      121              
  Lines        9155     9155              
==========================================
+ Hits         5166     5171       +5     
+ Misses       3460     3455       -5     
  Partials      529      529
Impacted Files Coverage Δ
go/scheduler/tests/tester.go 91.42% <0%> (-2.86%) ⬇️
go/roothash/tests/tester.go 92.7% <0%> (ø) ⬆️
go/scheduler/trivial/trivial.go 75.09% <0%> (+1.16%) ⬆️
go/scheduler/alg/greedy_subgraphs_scheduler.go 89.47% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b8fa4f...3095d8e. Read the comment docs.

@kostko
Copy link
Member Author

kostko commented Nov 12, 2018

Actually, tarpaulin seems to be doing something strange when building/linking binaries as it seems to be unable to build *-untrusted even though normal Cargo build works.

@kostko
Copy link
Member Author

kostko commented Nov 12, 2018

It may be related to xd009642/tarpaulin#126 (which mentions -C link-dead-code) so we can just disable coverage of untrusted parts for now.

@kostko kostko force-pushed the kostko/feature/rust-coverage branch from 70f2536 to 835ab3d Compare November 12, 2018 14:54
@kostko kostko force-pushed the kostko/feature/rust-coverage branch 2 times, most recently from 2c59121 to 3095d8e Compare November 12, 2018 17:10
@kostko kostko merged commit bc3fb09 into master Nov 12, 2018
@kostko kostko deleted the kostko/feature/rust-coverage branch November 12, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants