Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): windows socket.connect syscall #3387

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Sep 25, 2024

Ref: #3251


PR-Codex overview

This PR focuses on enhancing the handling of network socket connections in the Win32 environment, specifically improving the inet_addr function and adding tests for both POSIX and Win32 socket connections.

Detailed summary

  • Added tests for valid POSIX and Win32 inet_addr handling.
  • Modified inet_addr in InetAddrSyscall.java to reverse bytes.
  • Implemented connect and WSAGetLastError functions in Winsock.java.
  • Updated EOwin32$EOφ to include new socket functions.
  • Created InetAddrFuncCall and ConnectFuncCall for Win32.
  • Enhanced error handling in socket connection tests.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 26, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 9b3e241 into objectionary:master Sep 26, 2024
20 checks passed
@rultor
Copy link
Contributor

rultor commented Sep 26, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 33min)

@0crat
Copy link

0crat commented Sep 26, 2024

@yegor256 Hey there! 👋 Thanks for your review work! You've earned +4 points this time. Here's the breakdown: +4 base points, -10 for having just 4 comments (we love feedback!), and +10 to keep you motivated. Remember, more code and comments can boost your score next time! Your current balance is -67. Keep up the good work and let's see that number climb! 💪

@0crat
Copy link

0crat commented Sep 26, 2024

@maxonfjvipon Hey there, coding champ! 👋 Thanks for your contribution! You've snagged +4 points this time around. Here's the breakdown: +4 base points, -8 for your 465 hits-of-code (over 200), -4 for only 3 comments (we love feedback!), and +12 to keep you motivated. Remember, quality and speed are key! Keep the code coming, but aim for smaller, more focused contributions next time. Your current balance is +40. Keep up the great work! 💻🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants