Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#715): Use EO Bytes Objects For Values #721

Merged
merged 17 commits into from
Sep 23, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Sep 23, 2024

In this PR I changed direct usage of bytes to bytes object usage (from EO lang).
In other words, was:

<o base="org.eolang.jeo.int" name="access" data="bytes">00 00 00 00 00 00 00 03</o>

Become:

<o base="org.eolang.jeo.int" name="access">
    <o base="bytes" data="bytes">00 00 00 00 00 00 00 04</o>
</o>

Closes: #715.
History:


PR-Codex overview

This PR focuses on refactoring the DirectivesData class to DirectivesValue, improving the handling of XML representations, and enhancing the overall structure of directive-related classes in the org.eolang.jeo.representation.directives and org.eolang.jeo.representation.xmir packages.

Detailed summary

  • Renamed DirectivesData to DirectivesValue.
  • Updated constructors and methods to use DirectivesValue.
  • Introduced DirectivesBytes for handling byte directives.
  • Enhanced XML processing with XmlValue and XmlBytes classes.
  • Refactored various classes to improve readability and maintainability.
  • Adjusted tests to reflect changes in directive handling and XML structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 23, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 99f9dc0 into objectionary:master Sep 23, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Sep 23, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 29min)

@0crat
Copy link

0crat commented Sep 23, 2024

@volodya-lombrozo Great work on your contribution! 🎉 You've earned +4 points, with adjustments for code volume and review. While there's room for improvement in code size and comments, we appreciate your effort. Your balance is now +97. Keep the contributions coming and check out our tips on balancing speed and quality. Looking forward to your next submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use bytes base for all values
4 participants