Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Node 14, raise minimum version to 16 #451

Merged
merged 2 commits into from
May 10, 2023
Merged

Remove support for Node 14, raise minimum version to 16 #451

merged 2 commits into from
May 10, 2023

Conversation

levibuzolic
Copy link
Contributor

@levibuzolic levibuzolic commented Apr 17, 2023

As discussed in #450, this raises the minimum node version support to 16 to fix some compatibility issues with the latest version of various dependencies.

#450 (comment)

@oblador
Copy link
Owner

oblador commented Apr 17, 2023

I suspect the failing integration test is due to the SB 7 release that somehow broke stuff. Does it pass on master for you?

.nvmrc Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@levibuzolic
Copy link
Contributor Author

@oblador I suspect the failing integration test is due to the SB 7 release that somehow broke stuff. Does it pass on master for you?

master doesn't pass locally anymore because Storybook 7 also requires Node 16 now.

@levibuzolic
Copy link
Contributor Author

@oblador Digging into the failure a little bit more, it looks Storybook 7 requires a web server because they've switched to usedusing JavaScript modules (.mjs) which can't be loaded from the local filesystem.

I quickly hacked in a http-server wrapper around the static build (though we might as well just run the storybook server directly) which gets a little further, however it looks like loki isn't compatible with Storybook 7, so that'll need to be fixed first.

@oblador
Copy link
Owner

oblador commented May 7, 2023

@levibuzolic 0.31.2 is out now with storybook 7 fixes, could you please give it another try? 🙏

Update node engine to >=16

Co-authored-by: Tomas Echeverri <[email protected]>
@levibuzolic
Copy link
Contributor Author

@oblador should be good to go now.

@oblador
Copy link
Owner

oblador commented May 10, 2023

Thanks!

@oblador oblador merged commit b568cac into oblador:master May 10, 2023
@levibuzolic levibuzolic deleted the node-16 branch May 10, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants