Update target-chrome-docker's runningInDocker check for cgroupsv2 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My biggest question is why we need this check at all. Doing the docker inspect unconditionally seems to work for me, and using the container's IP address should always be better I'd think? |
This was referenced Oct 11, 2023
This fixes docker-in-docker for me, particularly in gitlab. Without this, it tries to connect to 127.0.0.1 rather than the container's correct IP address and fails with a timeout.
oblador
force-pushed
the
fix-running-in-docker-check
branch
from
ca4700e
to
fdaa20a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes docker-in-docker for me, particularly in gitlab. Without this, it tries to connect to 127.0.0.1 rather than the container's correct IP address and fails with a timeout.
See benfred/py-spy#614
Fixes #421