Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove override of createJSModules #516

Merged
merged 4 commits into from
Jul 30, 2017
Merged

Remove override of createJSModules #516

merged 4 commits into from
Jul 30, 2017

Conversation

fractalwrench
Copy link
Contributor

Fixes #515

@oblador
Copy link
Owner

oblador commented Jul 18, 2017

Thanks! Is this a breaking change for older rn versions?

@fractalwrench
Copy link
Contributor Author

I'm quite new to RN so am not entirely sure. The commit message in the facebook repo suggests that previously this was necessary.

@fractalwrench
Update VectorIconsPackage.java
5f7f859 
remove override annotation, this allows for backwards compatibility.
@fractalwrench fractalwrench mentioned this pull request Jul 19, 2017
Merged
@oblador
Copy link
Owner

oblador commented Jul 30, 2017

Cool, thanks a lot!

@oblador oblador merged commit b7599a0 into oblador:master Jul 30, 2017
@oblador oblador mentioned this pull request Jul 30, 2017
Closed
@oblador
Copy link
Owner

oblador commented Jul 30, 2017

Released in 4.3.0!

This was referenced Aug 24, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @oblador