Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #1759 NTR valve endothelial cell #1763

Merged
2 commits merged into from
Dec 9, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 9, 2022

Addresses #1759 NTR valve endothelial cell
#gogoeditdiff

Appears to contain some extra changes from the recently merged PR #1727. (EDIT: these have been removed)

@ghost ghost mentioned this pull request Dec 9, 2022
@ghost ghost self-assigned this Dec 9, 2022
@ghost ghost added the new term request label Dec 9, 2022
@ghost ghost linked an issue Dec 9, 2022 that may be closed by this pull request
@ghost ghost requested review from emquardokus and shawntanzk December 9, 2022 12:22
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-12-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-12-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4030033 http://purl.obolibrary.org/obo/CL_4030033

Added

cardiac valve cell http://purl.obolibrary.org/obo/CL_1000147

Removed

Added

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4030033 http://purl.obolibrary.org/obo/CL_4030033

Added

cardiac valve cell http://purl.obolibrary.org/obo/CL_1000147

Removed

Added

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
@dosumis
Copy link
Contributor

dosumis commented Dec 9, 2022

Declarations can happen depending on how you add new terms for import. If you paste the IRIs straight into Protege, that => a declaration in the edit file.

@ghost
Copy link
Author

ghost commented Dec 9, 2022

Declarations can happen depending on how you add new terms for import. If you paste the IRIs straight into Protege, that => a declaration in the edit file.

Yes, I have done that for other tickets as it is listed as the first option here. The page says this method is "to be avoided" but does not give a reason and it has consistently worked for prior tickets.

The declarations appearing in this PR, however, are a surprise since I did not add them. If I had to guess, they may be coming from PR #1727 since they all seem to appear there.
Regardless, I'll delete the declarations in this PR and then merge.

removing unexpected declarations
@shawntanzk
Copy link
Contributor

OH! yeah I rmbr writing that, the reason its there was this:

This workflow is to be avoided, but may be appropriate if the editor does not have access to the ODK docker container. 

We should consider removing that whole part and just saying make a request for someone to import the term for you >.<

But yeah, probs best not to use it, its a hacky work around that might cause issues down the road

@dosumis
Copy link
Contributor

dosumis commented Dec 9, 2022

{ Off topic for this PR but: adding IRIs directly has the great advantage that it can be used instantly without having to wait for someone to help or disrupting your editing flow run a slow import update. I wonder if we should tolerate it and have a clean-up job that removes stray declarations from the edtor's file. Alternatively maybe we could have some super minimal temp import update (say IRI + label only) that editors can use rapidly while working on a PR, postponing a full update to later - Maybe add to agenda for Monday tech call? }

@ghost ghost merged commit c09db3c into master Dec 9, 2022
@ghost
Copy link
Author

ghost commented Dec 9, 2022

The following new term has been added to CL and will be available in the next release:

CL:4030033 'valve endothelial cell'

@shawntanzk
Copy link
Contributor

Should this have the GO term attached to it like in #1761?

@ghost
Copy link
Author

ghost commented Dec 9, 2022

Should this have the GO term attached to it like in #1761?

Not totally sure about this... the reference notes they secrete paracrine molecules, but I have not found a reference that explicitly states VECs secrete extracellular matrix constituents. Activated VICs are noted explicitly to secrete fibrous matrix proteins (collagen), which is why the GO axiom was added to that term.

From https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4485434/:

"VECs also secrete paracrine factors, including nitric oxide, endothelin-1, and C-type natriuretic peptide. Most biochemical factors secreted by VECs (except endothelin-1) function to reduce the pathogenic phenotypes of VICs."

vs.

"In addition, VICs secrete fibrous matrix proteins, matrix metalloproteinases (such as MMP1 and MMP2), biochemical factors, and can differentiate into myofibroblasts or osteoblast-like cells or undergo cell death-mediated calcification"

If you think appropriate, I could edit the text definition and/or add a less specific axiom regarding secretion.

@anitacaron anitacaron mentioned this pull request Dec 9, 2022
@ghost ghost deleted the 1759-NTR-valve_endothelial_cell branch January 19, 2023 13:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] 'valve endothelial cell'
2 participants