Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change has_completed to obo:RO_0002353 #1770

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Conversation

shawntanzk
Copy link
Contributor

#gogoeditdiff
see oborel/obo-relations#574 (comment)
Also tagging @bpeters42
Please do see the automated diff (once it comes up) to ensure that changes are accurate.
Thanks

@shawntanzk shawntanzk self-assigned this Dec 14, 2022
@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-01-04/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-01-04/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

has_completed http://purl.obolibrary.org/obo/cl#has_completed

Removed

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

Bm4 B cell http://purl.obolibrary.org/obo/CL_0000966

Removed

Added

Bm5 B cell http://purl.obolibrary.org/obo/CL_0000967

Removed

Added

CD27-negative gamma-delta T cell http://purl.obolibrary.org/obo/CL_0002125

Removed

Added

CD27-positive gamma-delta T cell http://purl.obolibrary.org/obo/CL_0002124

Removed

Added

CD4-positive helper T cell http://purl.obolibrary.org/obo/CL_0000492

Removed

Added

CD4-positive, alpha-beta cytotoxic T cell http://purl.obolibrary.org/obo/CL_0000934

Removed

Added

CD4-positive, alpha-beta memory T cell http://purl.obolibrary.org/obo/CL_0000897

Removed

Added

CD4-positive, alpha-beta memory T cell, CD45RO-positive http://purl.obolibrary.org/obo/CL_0001204

Removed

Added

CD8-positive, alpha-beta cytokine secreting effector T cell http://purl.obolibrary.org/obo/CL_0000908

Removed

Added

CD8-positive, alpha-beta cytotoxic T cell http://purl.obolibrary.org/obo/CL_0000794

Removed

Added

CD8-positive, alpha-beta memory T cell http://purl.obolibrary.org/obo/CL_0000909

Removed

Added

CD8-positive, alpha-beta memory T cell, CD45RO-positive http://purl.obolibrary.org/obo/CL_0001203

Removed

Added

class switched memory B cell http://purl.obolibrary.org/obo/CL_0000972

Removed

Added

effector T cell http://purl.obolibrary.org/obo/CL_0000911

Removed

Added

effector memory CD4-positive, alpha-beta T cell, terminally differentiated http://purl.obolibrary.org/obo/CL_0001087

Removed

Added

effector memory CD8-positive, alpha-beta T cell, terminally differentiated http://purl.obolibrary.org/obo/CL_0001062

Removed

Added

has_completed http://purl.obolibrary.org/obo/cl#has_completed

Removed

mature B cell http://purl.obolibrary.org/obo/CL_0000785

Removed

Added

mature NK T cell http://purl.obolibrary.org/obo/CL_0000814

Removed

Added

mature T cell http://purl.obolibrary.org/obo/CL_0002419

Removed

Added

mature alpha-beta T cell http://purl.obolibrary.org/obo/CL_0000791

Removed

Added

mature gamma-delta T cell http://purl.obolibrary.org/obo/CL_0000800

Removed

Added

memory B cell http://purl.obolibrary.org/obo/CL_0000787

Removed

Added

memory T cell http://purl.obolibrary.org/obo/CL_0000813

Removed

Added

memory regulatory T cell http://purl.obolibrary.org/obo/CL_0002678

Removed

Added

mucosal invariant T cell http://purl.obolibrary.org/obo/CL_0000940

Removed

Added

naive T cell http://purl.obolibrary.org/obo/CL_0000898

Removed

Added

non-classical monocyte http://purl.obolibrary.org/obo/CL_0000875

Removed

Added

pre-B-II cell http://purl.obolibrary.org/obo/CL_0000955

Removed

Added

@shawntanzk
Copy link
Contributor Author

@addiehl Could you also give a positive review before I merge this, would be more comfortable if you go through this too. Thanks :)

@shawntanzk
Copy link
Contributor Author

#gogoeditdiff

@shawntanzk
Copy link
Contributor Author

Not 100% sure why the QC isn't autorunning, but manually triggered it and it passed https:/obophenotype/cell-ontology/actions/runs/3847578786

@shawntanzk
Copy link
Contributor Author

Merging this given the time has passed, please open a new ticket if there is any issues

@shawntanzk shawntanzk merged commit d7ea4ec into master Jan 19, 2023
@shawntanzk shawntanzk deleted the remove-has_completed branch January 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants