-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses #1827 NTR peg cell #1828
Conversation
Addresses 1827 NTR peg cell
src/ontology/cl-edit.owl
Outdated
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:22911892"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4033014 "intercalary cell") | ||
AnnotationAssertion(rdfs:label obo:CL_4033014 "peg cell") | ||
SubClassOf(obo:CL_4033014 obo:CL_0000151) | ||
SubClassOf(obo:CL_4033014 obo:CL_1001591) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there evidence to support this assertion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this definitional? 'fallopian tube epithelium' = 'oviduct epithelium' in Uberon. This seems reasonable given:
https://en.wikipedia.org/wiki/Fallopian_tube
However, Uberon structure looks quite broken here as the term appears to cover many different epithelia of the female reproductive system.
- TODO Add Uberon ticket on this. Might be complicated due to cross-species nature of ontology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted above, PMID:22911892 seems to only investigate the fallopian tube epithelium as opposed to whole oviduct. Is there a reference (other than BTO) that reports this cell in other locations of the oviduct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes in the comments
src/ontology/cl-edit.owl
Outdated
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:22911892"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4033014 "intercalary cell") | ||
AnnotationAssertion(rdfs:label obo:CL_4033014 "peg cell") | ||
SubClassOf(obo:CL_4033014 obo:CL_0000151) | ||
SubClassOf(obo:CL_4033014 obo:CL_1001591) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this definitional? 'fallopian tube epithelium' = 'oviduct epithelium' in Uberon. This seems reasonable given:
https://en.wikipedia.org/wiki/Fallopian_tube
However, Uberon structure looks quite broken here as the term appears to cover many different epithelia of the female reproductive system.
- TODO Add Uberon ticket on this. Might be complicated due to cross-species nature of ontology.
#gogoeditdiff |
Your branch is 13 commit/s behind, please update your branch. |
#gogoeditdiff |
src/ontology/cl-edit.owl
Outdated
AnnotationAssertion(<http://purl.org/dc/terms/contributor> obo:CL_4033014 <https://orcid.org/0000-0001-6677-8489>) | ||
AnnotationAssertion(<http://purl.org/dc/terms/date> obo:CL_4033014 "2023-02-02T15:07:12Z"^^xsd:dateTime) | ||
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:22911892"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4033014 "FTE stem-like cell") | ||
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:22911892"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4033014 "FTESC") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding has_synonym_type "abbreviation". Can refer to CL:4030035 'dental pulp stem cell' for an example.
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsCL_4033014
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsCL_4033014
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
…ell-ontology into 1827_NTR_peg_cell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on text def.
Otherwise OK.
#gogoeditdiff |
#gogoeditdiff |
Resolves #1827 NTR peg cell