Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #1827 NTR peg cell #1828

Merged
merged 11 commits into from
Feb 9, 2023
Merged

Addresses #1827 NTR peg cell #1828

merged 11 commits into from
Feb 9, 2023

Conversation

aleixpuigb
Copy link
Collaborator

Resolves #1827 NTR peg cell

Addresses 1827 NTR peg cell
@aleixpuigb aleixpuigb requested a review from a user February 2, 2023 15:22
@aleixpuigb aleixpuigb self-assigned this Feb 2, 2023
@aleixpuigb aleixpuigb added new term request HuBMAP Needed/useful for HuBMAP labels Feb 2, 2023
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:22911892"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4033014 "intercalary cell")
AnnotationAssertion(rdfs:label obo:CL_4033014 "peg cell")
SubClassOf(obo:CL_4033014 obo:CL_0000151)
SubClassOf(obo:CL_4033014 obo:CL_1001591)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there evidence to support this assertion?

Copy link
Contributor

@dosumis dosumis Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this definitional? 'fallopian tube epithelium' = 'oviduct epithelium' in Uberon. This seems reasonable given:

image https://en.wikipedia.org/wiki/Fallopian_tube

However, Uberon structure looks quite broken here as the term appears to cover many different epithelia of the female reproductive system.

  • TODO Add Uberon ticket on this. Might be complicated due to cross-species nature of ontology.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted above, PMID:22911892 seems to only investigate the fallopian tube epithelium as opposed to whole oviduct. Is there a reference (other than BTO) that reports this cell in other locations of the oviduct?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes in the comments

AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:22911892"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4033014 "intercalary cell")
AnnotationAssertion(rdfs:label obo:CL_4033014 "peg cell")
SubClassOf(obo:CL_4033014 obo:CL_0000151)
SubClassOf(obo:CL_4033014 obo:CL_1001591)
Copy link
Contributor

@dosumis dosumis Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this definitional? 'fallopian tube epithelium' = 'oviduct epithelium' in Uberon. This seems reasonable given:

image https://en.wikipedia.org/wiki/Fallopian_tube

However, Uberon structure looks quite broken here as the term appears to cover many different epithelia of the female reproductive system.

  • TODO Add Uberon ticket on this. Might be complicated due to cross-species nature of ontology.

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
@aleixpuigb aleixpuigb requested a review from a user February 7, 2023 10:26
@anitacaron
Copy link
Contributor

#gogoeditdiff

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Your branch is 13 commit/s behind, please update your branch.

@anitacaron
Copy link
Contributor

#gogoeditdiff

AnnotationAssertion(<http://purl.org/dc/terms/contributor> obo:CL_4033014 <https://orcid.org/0000-0001-6677-8489>)
AnnotationAssertion(<http://purl.org/dc/terms/date> obo:CL_4033014 "2023-02-02T15:07:12Z"^^xsd:dateTime)
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:22911892"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4033014 "FTE stem-like cell")
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:22911892"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4033014 "FTESC")
Copy link

@ghost ghost Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding has_synonym_type "abbreviation". Can refer to CL:4030035 'dental pulp stem cell' for an example.

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-02-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-02-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4033014 http://purl.obolibrary.org/obo/CL_4033014

Added

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4033014 http://purl.obolibrary.org/obo/CL_4033014

Added

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on text def.
Otherwise OK.

@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@aleixpuigb aleixpuigb merged commit 2a23ea6 into master Feb 9, 2023
@aleixpuigb aleixpuigb deleted the 1827_NTR_peg_cell branch February 9, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HuBMAP Needed/useful for HuBMAP new term request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[NTR] Peg cell
3 participants