Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import "blood nerve barrier" from UBERON #1842

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

aleixpuigb
Copy link
Collaborator

Import UBERON:0003209 "blood nerve barrier" to CL

Context
#1832 The perineurium is part of the "blood nerve barrier". Importing this term, the perineurial cell will be inferred to be part of the 'blood nerve barrier' as well.

Import blood nerve barrier from UBERON
@aleixpuigb aleixpuigb requested a review from a user February 8, 2023 09:42
@aleixpuigb aleixpuigb self-assigned this Feb 8, 2023
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontologies are identical

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

blood nerve barrier http://purl.obolibrary.org/obo/UBERON_0003209

Added

@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this axiom to perineurium in CL (it is already in Uberon):
'part of' some 'blood nerve barrier'

After adding this, running the following DL query will return 'perineurial cell':
cell and 'part of' some 'blood nerve barrier'

@aleixpuigb
Copy link
Collaborator Author

aleixpuigb commented Feb 8, 2023

Please add this axiom to perineurium in CL (it is already in Uberon):
'part of' some 'blood nerve barrier'

@anitacaron, I have already added this axiom in UBERON (+ update text definition of perineurium). Will these edits be reflected in CL in the future, or should I update them manually in CL?

@dosumis
Copy link
Contributor

dosumis commented Feb 8, 2023

Please add this axiom to perineurium in CL (it is already in Uberon):
'part of' some 'blood nerve barrier'

@anitacaron, I have already added this axiom in UBERON (+ update text definition of perineurium). Will these edits be reflected in CL in the future, or should I update them manually in CL?

This will come in via import update. We should never make axioms in CL, or any other ontology we work on, linking terms from external ontologies.

@aleixpuigb
Copy link
Collaborator Author

Thank you, @dosumis. I will merge the branch only with the import, then.

@aleixpuigb aleixpuigb requested a review from a user February 8, 2023 12:57
@aleixpuigb aleixpuigb merged commit d5c5793 into master Feb 8, 2023
@aleixpuigb aleixpuigb deleted the import_blood_nerve_barrier branch February 8, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants