Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change telocyte and lymphoblast subclass to seperate subclass #2087

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

shawntanzk
Copy link
Contributor

Fixes #2086

Previously was intersection, making them orphany
note: not 100% sure about implication, but I think this is correct?
Either way, should probably have explicit parentage
thoughts @aleixpuigb and/or @bvarner-ebi?

Thanks

@shawntanzk shawntanzk requested review from aleixpuigb and a user August 3, 2023 14:24
@shawntanzk shawntanzk self-assigned this Aug 3, 2023
@addiehl
Copy link
Contributor

addiehl commented Aug 3, 2023

Split them up. The split up axioms are logically equivalent to the combined one, in that there is an implicit 'and' between subclass axioms, in any case, but obviously tools are confused.

Copy link
Contributor

@lubianat lubianat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me as far as I can tell.

@shawntanzk shawntanzk merged commit fef9ca4 into master Aug 4, 2023
1 check passed
@shawntanzk shawntanzk deleted the issue-2086 branch August 4, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telocyte and Lymphoblast do not have explicit parents
3 participants