Addresses #2079 Merge 'choroid plexus cell' into 'choroid plexus epithelial cell' #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2023 10:39
ghost
self-assigned this
ghost
requested a review
from 
|
FYI @emquardokus, in this merge 'choroid plexus cell' was obsoleted and removed from the subset human_reference_atlas. 'choroid plexus epithelial cell' was added to the subset human_reference_atlas. |
ran: sh run.sh make all_subsets -B
|
CC @anitacaron, will you kindly take a look at the updated subset files? |
aleixpuigb
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Concerning the merge and obsoletion, everything looks fine.
About the HRA subset, the label was manually added, and I can't see any HRA template to add terms automatically. Therefore I don't think updating the subsets was needed, but it shouldn't break anything. However, I will defer the review of the subsets to @anitacaron.
anitacaron
requested changes
Aug 9, 2023
removed human_reference_atlas subset
anitacaron
requested changes
Aug 14, 2023
added 2 commits
August 15, 2023 15:18
This reverts commit 9dd63cc.
revert changes
anitacaron
approved these changes
Aug 15, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2079 Merge 'choroid plexus cell' into 'choroid plexus epithelial cell'
and updated subsets