Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR: add mesenchymal stem cell of orbital adipose tissue #2153

Merged
1 commit merged into from
Sep 20, 2023

Conversation

paulacalipho
Copy link
Collaborator

fixes #2152

@paulacalipho paulacalipho self-assigned this Sep 18, 2023
@ghost ghost self-requested a review September 18, 2023 11:16
@dosumis
Copy link
Contributor

dosumis commented Sep 18, 2023

#gogoeditdiff

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-09-18/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-09-18/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4040004 http://purl.obolibrary.org/obo/CL_4040004

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4040004 http://purl.obolibrary.org/obo/CL_4040004

Added

Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One thing that might improve it is if we had a term for adipose tissue of ocular region in Uberon. I wouldn't want this to be a blocker, but please consider adding an uberon ticket on this, referencing this term. Thanks!

@ghost ghost removed their request for review September 18, 2023 11:59
@paulacalipho
Copy link
Collaborator Author

thanks @dosumis for reviewing this term. UBERON_0006671 orbital fat pad has exact synonyms: orbital fat body, retrobulbar fat, orbital fat, intraorbital fat pad. The term you suggest "adipose tissue of ocular region" could be added as synonym of UBERON_0006671? Or you suggest to create a separate term?

@ghost ghost merged commit 07634dd into master Sep 20, 2023
1 check passed
@paulacalipho paulacalipho deleted the #2152-NTR-mesenchymal-stem-cell-of-orbital-adipose-tissue branch September 20, 2023 11:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] mesenchymal stem cell of orbital adipose tissue
2 participants