Added ‘has soma location’ RO:0002100 to get_scope_query method #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleixpuigb
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
I base the review on the output, but not on the code.
Adding the object property 'has soma location' to the query increases the number of cell types that are located in a certain organ (in the eye in this case).
Therefore, as 'retinal ganglion cell' is not in the slim list, all the terms under this class are only captured when 'has soma location' has been added, dropping the coverage percentage.
It might still be good that another person reviews the code, but I will leave it to the assignee's consideration.
|
We can merge it since nothing major has changed in the code |
dosumis
approved these changes
Oct 7, 2023
aleixpuigb
deleted the
1955-slim-coverage-report-add-has-soma-location
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1955
Tested it with eye_upper_slim.csv and UBERON:0000970. You can see the output of coverage calculation below.
eye_slim_test_no_soma.csv
eye_slim_test.csv