Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #2259 NTR placental terms #2262

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

aleixpuigb
Copy link
Collaborator

Addresses #2259 NTR placental terms

Addresses #2259 NTR placental terms
@aleixpuigb aleixpuigb added new term request HuBMAP Needed/useful for HuBMAP labels Jan 8, 2024
@aleixpuigb aleixpuigb self-assigned this Jan 8, 2024
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

Copy link

github-actions bot commented Jan 9, 2024

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-01-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-01-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4033062 http://purl.obolibrary.org/obo/CL_4033062

Added

CL_4033063 http://purl.obolibrary.org/obo/CL_4033063

Added

CL_4033064 http://purl.obolibrary.org/obo/CL_4033064

Added

Copy link

github-actions bot commented Jan 9, 2024

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4033062 http://purl.obolibrary.org/obo/CL_4033062

Added

CL_4033063 http://purl.obolibrary.org/obo/CL_4033063

Added

CL_4033064 http://purl.obolibrary.org/obo/CL_4033064

Added

dosumis
dosumis previously approved these changes Jan 9, 2024
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One tiny change suggested 'some uterus' --> 'the uterus'. Biologists find the logical terminology confusing - especially in the context of organs where only one is present per organism.

@aleixpuigb
Copy link
Collaborator Author

Looks good to me. One tiny change suggested 'some uterus' --> 'the uterus'. Biologists find the logical terminology confusing - especially in the context of organs where only one is present per organism.

Thank you for the suggestion, I will change that.

@aleixpuigb aleixpuigb merged commit bf0391d into master Jan 9, 2024
1 check passed
@aleixpuigb aleixpuigb deleted the 2259_NTR_placenta_terms branch January 9, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HuBMAP Needed/useful for HuBMAP new term request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] Placental new terms - extravillous trophoblast cells + uterine macrophage
2 participants