Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERON:0000949 endocrine system uses obsolete GO:0050886 endocrine process #3019

Closed
raymond91125 opened this issue Aug 15, 2023 · 4 comments · Fixed by #3039
Closed

UBERON:0000949 endocrine system uses obsolete GO:0050886 endocrine process #3019

raymond91125 opened this issue Aug 15, 2023 · 4 comments · Fixed by #3039
Assignees

Comments

@raymond91125
Copy link

Uberon term
UBERON:0000949 endocrine system

Suggested revision of logical definition
'endocrine system' EquivalentTo 'non-connected functional system' and ('capable of' some 'endocrine process')

GO:0050886 endocrine process is to be obsoleted because it is ill defined.
geneontology/go-ontology#17084
Perhaps change LD to something like (per obophenotype/cell-ontology#1706)
'non-connected functional system' and 'capable of' some ('hormone secretion' and ('has target end location' some 'circulatory system'))

@aleixpuigb
Copy link
Collaborator

I agree with the LD that you propose, since looking at this comment, 'endocrine hormone secretion' and 'regulation of endocrine secretion' are also planned to be obsoleted.

@aleixpuigb
Copy link
Collaborator

aleixpuigb commented Aug 21, 2023

Uberon has a problem with this LD because it is in obo format, and I might have to split it in Subclasses:

image
image

I will bring this ticket to the Uberon call.

@aleixpuigb
Copy link
Collaborator

aleixpuigb commented Aug 22, 2023

Hi @raymond91125,
In the Uberon ontology call (21/08/23) it was decided that this term doesn't need a logical definition. Instead we can use a hidden GCI by adding SubclassOf 'part of' some 'endocrine system' to 'endocrine cell', which have a LD EquivalentTo 'native cell' and ('capable of' some ('hormone secretion' and ('has target end location' some 'circulatory system'))).
Do you agree with this solution?

@raymond91125
Copy link
Author

The GO term used (hormone secretion) is stable so we are good. Thanks.

aleixpuigb added a commit that referenced this issue Aug 23, 2023
Fixes #3019 Removes logical definition of 'endocrine system'
aleixpuigb added a commit that referenced this issue Aug 23, 2023
…ystem

Fixes #3019 Removes logical definition of 'endocrine system'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants