Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2583 - Auto detect os on Install page & persist selected os #2758

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

piotr-m-jurek
Copy link
Contributor

@piotr-m-jurek piotr-m-jurek commented Oct 9, 2024

Fixes #2583.

  • when user enters link /install without hash, gets redirected to detected os specific instructions
  • when user enters link with hashed os name, stays on the hashed page, instead of switching to os

Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @piotr-m-jurek, this improves the behavior of linking to specific install instructions!

Merging when CI finishes. ✨

@sabine sabine changed the title Fix #2583 - Auto detect os & persist selected os Fix #2583 - Auto detect os on Install page & persist selected os Oct 11, 2024
@cuihtlauac cuihtlauac merged commit 275e1bd into ocaml:main Oct 11, 2024
3 checks passed
@piotr-m-jurek piotr-m-jurek deleted the os-fix branch October 11, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to specific platform installation instructions
3 participants