Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] cohttp, cohttp-top, cohttp-mirage, cohttp-lwt, cohttp-lwt-unix, cohttp-lwt-jsoo and cohttp-async (5.0.0) #20246

Merged
merged 4 commits into from
Jan 5, 2022

Commits on Dec 17, 2021

  1. [new release] cohttp, cohttp-top, cohttp-mirage, cohttp-lwt, cohttp-l…

    …wt-unix, cohttp-lwt-jsoo and cohttp-async (5.0.0)
    
    CHANGES:
    
    - Cohttp.Header: new implementation (lyrm mirage/ocaml-cohttp#747)
    
      + New implementation of Header modules using an associative list instead of a map, with one major semantic change (function ```get```, see below), and some new functions (```clean_dup```, ```get_multi_concat```)
      + More Alcotest tests as well as fuzzing tests for this particular module.
    
      ### Purpose
    
      The new header implementation uses an associative list instead of a map to represent headers and is focused on predictability and intuitivity: except for some specific and documented functions, the headers are always kept in transmission order, which makes debugging easier and is also important for [RFC7230§3.2.2](https://tools.ietf.org/html/rfc7230#section-3.2.2) that states that multiple values of a header must be kept in order.
    
      Also, to get an intuitive function behaviour, no extra work to enforce RFCs is done by the basic functions. For example, RFC7230§3.2.2 requires that a sender does not send multiple values for a non list-value header. This particular rule could require the ```Header.add``` function to remove previous values of non-list-value headers, which means some changes of the headers would be out of control of the user. With the current implementation, an user has to actively call dedicated functions to enforce such RFCs (here ```Header.clean_dup```).
    
      ### Semantic changes
      Two functions have a semantic change : ```get``` and ```update```.
    
      #### get
      ```get``` was previously doing more than just returns the value associated to a key; it was also checking if the searched header could have multiple values: if not, the last value associated to the header was returned; otherwise, all the associated values were concatenated and returned. This semantics does not match the global idea behind the new header implementation, and would also be very inefficient.
    
      + The new ```get``` function only returns the last value associated to the searched header.
      + ```get_multi_concat``` function has been added to get a result similar to the previous ```get``` function.
    
      #### update
      ```update``` is a pretty new function (mirage/ocaml-cohttp#703) and changes are minor and related to ```get``` semantic changes.
    
      + ```update h k f``` is now modifying only the last occurrences of the header ```k``` instead of all its occurrences.
      + a new function ```update_all``` function has been added and work on all the occurrences of the updated header.
    
      ### New functions :
    
      + ```clean_dup```  enables the user to clean headers that follows the {{:https://tools.ietf.org/html/rfc7230#section-3.2.2} RFC7230§3.2.2} (no duplicate, except ```set-cookie```)
      + ```get_multi_concat``` has been added to get a result similar to the previous ```get``` function.
    
    - Cohttp.Header: performance improvement (mseri, anuragsoni mirage/ocaml-cohttp#778)
      **Breaking** the headers are no-longer lowercased when parsed, the headers key comparison is case insensitive instead.
    
    - cohttp-lwt-unix: Adopt ocaml-conduit 5.0.0 (smorimoto mirage/ocaml-cohttp#787)
      **Breaking** `Conduit_lwt_unix.connect`'s `ctx` param type chaged from `ctx` to  `ctx Lazy.t`
    
    - cohttp-mirage: fix deprecated fmt usage (tmcgilchrist mirage/ocaml-cohttp#783)
    - lwt_jsoo: Use logs for the warnings and document it (mseri mirage/ocaml-cohttp#776)
    - lwt: Use logs to warn users about leaked bodies and document it (mseri mirage/ocaml-cohttp#771)
    - lwt, lwt_unix: Improve use of logs and the documentation, fix bug in the Debug.enable_debug function (mseri mirage/ocaml-cohttp#772)
    - lwt_jsoo: Fix exception on connection errors in chrome (mefyl mirage/ocaml-cohttp#761)
    - lwt_jsoo: Fix `Lwt.wakeup_exn` `Invalid_arg` exception when a js
      stack overflow happens in the XHR completion handler (mefyl mirage/ocaml-cohttp#762).
    - lwt_jsoo: Add test suite (mefyl mirage/ocaml-cohttp#764).
    mseri committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    3dcc2aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eeb4ff3 View commit details
    Browse the repository at this point in the history
  3. Retrigger CI

    mseri committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    0d8e76b View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2021

  1. h1_pareser, zeit: disable tests on cohttp 5

    Signed-off-by: Marcello Seri <[email protected]>
    mseri committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    22f861e View commit details
    Browse the repository at this point in the history