Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVD.predict MIN_VALUE parameter does not work if equal to 0.0 #5

Open
MikhailStartsev opened this issue Dec 8, 2013 · 1 comment
Open

Comments

@MikhailStartsev
Copy link

A piece of code:

if MIN_VALUE:
predicted_value = max(predicted_value, MIN_VALUE)
if MAX_VALUE:
predicted_value = min(predicted_value, MAX_VALUE)

0.0 is casted to False (ex.: "print "True" if 0.0 else "False" prints "False"), therefore you can still get results <0 even if you specify MIN_VALUE=0.0.

@ocelma
Copy link
Owner

ocelma commented Sep 7, 2014

Hi

I see. Please provide a patch to solve this issue, and I'll have a look at it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants