Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

feat(tsconfig): add support for custom typescript config #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iammathew
Copy link

Hey,

this MR tries to fix oclif/oclif#299 by adding a ENV to set a custom typescript config, nothing special, but enables users to set a custom tsconfig in development scenarios.

Cooler would be to be able to set it inside the oclif config, but as the ts-node module right now doesnt need to access it i didnt want to introduce a "dependency" there.

Let me know how I can improve this MR

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #152   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines          12      12           
  Branches        3       3           
======================================
  Misses         12      12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ea593...c205e43. Read the comment docs.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @khayalan-mathew to sign the Salesforce.com Contributor License Agreement.

@iammathew
Copy link
Author

@RasPhilCo @amphro
Sorry for not signing the CLA earlier, let me know what you think of it, so i can improve it :)

@amphro
Copy link
Contributor

amphro commented Oct 8, 2020

Seems simple enough. Out of curiosity, what are the development scenarios you talked about?

@iammathew
Copy link
Author

@amphro Im running oclif inside a nx workspace, right now i need to change a bit in the tsconfig to make the /bin/run working with typescript, this conflicts with the overall workspace rules, and some advanced behaviors like importing other packages using paths cause issues with the modifications oclif needs.

Hope that clears that up.

@humandad
Copy link

I'm also trying to use oclif with nx and would appreciate this feature. Is there anything blocking this?

@iammathew
Copy link
Author

@humandad Waiting for feedback, atm. But hopefully this can be merged soon :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom tsconfig file
3 participants