This repository has been archived by the owner on May 22, 2024. It is now read-only.
Replace custom stubbing with sinon #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @stephankaag to sign the Salesforce.com Contributor License Agreement. |
|
Great! This does need to be backwards compatible with the existing stubbing, willing to add that? (And in a future major release we can drop the compatibility). cc @chadian |
|
Like this, will require a major bump which is coming in the new year. cc @chadian |
|
This issue has been linked to a new work item: W-11816761 |
|
@stephankaag Thank you for this contribution! And apologies it's taken years to get this merged. I'm merging this into my own branch because I have a few other breaking changes I'm going to introduce before merging this to main |
Merged
mshanemc
pushed a commit
that referenced
this pull request
Sep 25, 2023
* Replace custom stubbing with sinon (#76) * Replace custom stubbing with sinon * Satisfy linter * Sinon is a dependency * Expose stub to user --------- Co-authored-by: Mike Donnalley <[email protected]> * feat!: node 18 minimum BREAKING CHANGE: node 18 minimum * chore: update eslint libs * chore: typescript 5 * chore: use mocha 10 * test: use salesforcecli workflow * chore: disable readme generation * chore: bump version * chore(release): 3.0.0-beta.1 [skip ci] * feat: use sinon 16 * chore(release): 3.0.0-beta.2 [skip ci] * chore: update readme * chore: update readme * chore: use ES2022 --------- Co-authored-by: Stephan Kaag <[email protected]> Co-authored-by: svc-cli-bot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I resolved the conflict in #30