Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

fix: add w to alphabet enums #28

Merged
merged 2 commits into from
Jun 15, 2018
Merged

fix: add w to alphabet enums #28

merged 2 commits into from
Jun 15, 2018

Conversation

tstapleton
Copy link
Contributor

i tried to use w as the shorter version for a command flag. typescript said it wasn't assignable.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @tstapleton to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented Jun 14, 2018 •
edited
Loading

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          11       11           
  Lines         302      302           
  Branches       80       80           
=======================================
  Hits          273      273           
  Misses         10       10           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd6df9...67284d9. Read the comment docs.

jdx
jdx reviewed Jun 14, 2018
View reviewed changes
test/parse.test.ts Outdated
@@ -77,6 +77,15 @@ describe('parse', () => {
expect(!!out.flags.myflag).to.equal(true)
expect(!!out.flags.force).to.equal(true)
})

it('knows "w" is a character', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we can do without the test, I'll go ahead and remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, of course. i was using that to see it fail and then fixed.

jdx
jdx reviewed Jun 14, 2018
View reviewed changes
Copy link
Contributor

@jdx jdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, if you wouldn't mind signing the CLA I'll happily merge

@jdx
Copy link
Contributor

jdx commented Jun 14, 2018

clearly I don't know my ABC's

@tstapleton
Copy link
Contributor Author

CLA signed @jdxcode . thanks!

@jdx
Copy link
Contributor

jdx commented Jun 15, 2018

I really appreciate the contribution!

@jdx jdx merged commit e78f250 into oclif:master Jun 15, 2018
oclif-bot added a commit that referenced this pull request Jun 15, 2018
@oclif-bot
chore(release): 3.5.2 [skip ci]
044b8ce 
<a name="3.5.2"></a>
## [3.5.2](v3.5.1...v3.5.2) (2018-06-15)

### Bug Fixes

* add w to alphabet enums ([#28](#28)) ([e78f250](e78f250))
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 3.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdx jdx jdx approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstapleton @jdx @oclif-bot