Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fish autocomplete #175

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

p-dealwis
Copy link

My branch comprises of changes from a recently closed PR. I have made the required changes to fix the unit tests and added in a missing one.

@salesforce-cla
Copy link

salesforce-cla bot commented Jan 7, 2021

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Pramodya De Alwis <p***@p***.c***.nz>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@salesforce-cla
Copy link

salesforce-cla bot commented Jan 7, 2021

Thanks for the contribution! Before we can merge this, we need @p-dealwis to sign the Salesforce.com Contributor License Agreement.

@p-dealwis
Copy link
Author

This ticket relates to the recently closed PR #5

@lenovouser
Copy link

Can this be merged?

@mdonnalley
Copy link
Contributor

@p-dealwis Are you still interested in getting this merged?

If so, does the fish autocompletion work with spaces? oclif introduced support for space delineated commands since you first submitted this PR so I'd prefer for any new autocomplete logic to support both spaces and colons

@p-dealwis
Copy link
Author

@mdonnalley I don't use fish anymore...nor do I use oclif. If anyone wants to go ahead and add autocompletion with spaces please be my guest :) Otherwise close the PR....

Yukaii added a commit to hackmdio/plugin-autocomplete that referenced this pull request Apr 29, 2023
@maastrich
Copy link

Will this PR be continued ?

@p-dealwis
Copy link
Author

@maastrich as per my comment above, please feel free to carry on from where I left off

@cristiand391
Copy link
Member

Hey all 👋🏼

Sorry for the radio silence here, I don't think we can provide an ETA about adding support for fish completion (even if we can re-use @p-dealwis's work, we'll have to commit to keep it up to date and at feature parity with bash, zsh and pwsh ).

As a side project, I was thinking about start working on a 3rd party oclif plugin for shells not supported by plugin-autocomplete yet, would you be interested in something like this? (👍🏼 👎🏼 )

@maastrich
Copy link

maastrich commented Jun 1, 2023

I'm currently working on something on a fork of mine, I make a PR soon, it kinds of rework a bit the project in order to be as agnostic as possible about shells that are used.

Will create a draft pull_request for review purposes ;)

It handles:

  • completion with spaces
  • completion with semi column
  • could handle more separators if needed

Thanks @cristiand391 for your time

PS: here is the PR from my fork (still need a rebase to retrieve PowerShell completion)

@cristiand391
Copy link
Member

fyi: I wrote a plugin to use oclif CLIs with carapace-spec, you can use it to get shell completion in a bunch of shells:
https:/cristiand391/oclif-carapace-spec-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants