Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose command help method #33

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Conversation

mattwiller
Copy link

This is part of a proposed solution to oclif/command#49 — the idea here is to directly expose the help generation logic for a known command, which can then be called directly in oclif/command to create the full help text in all cases.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @mattwiller to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #33 into master will increase coverage by 0.1%.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #33     +/-   ##
========================================
+ Coverage    74.4%   74.5%   +0.1%     
========================================
  Files           7       7             
  Lines         254     255      +1     
  Branches       78      78             
========================================
+ Hits          189     190      +1     
  Misses         27      27             
  Partials       38      38
Impacted Files Coverage Δ
src/index.ts 65.21% <81.81%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d4a6c...a1114fe. Read the comment docs.

Copy link
Contributor

@jdx jdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jdx jdx merged commit 0c0a0d9 into oclif:master Nov 12, 2018
oclif-bot added a commit that referenced this pull request Nov 12, 2018
## [2.1.4](v2.1.3...v2.1.4) (2018-11-12)

### Bug Fixes

* Expose command help method ([#33](#33)) ([0c0a0d9](0c0a0d9))
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants