Unskip pagination tests and set page sizes correctly

octokit · Aug 8, 2017 · 1fbee42 · 1fbee42
1 parent 595e6e2
commit 1fbee42
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/Octokit.Tests.Integration/Clients/OrganizationOutsideCollaboratorsClientTests.cs b/Octokit.Tests.Integration/Clients/OrganizationOutsideCollaboratorsClientTests.cs
@@ -126,19 +126,19 @@ public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithAllFilterAndApiOp
  var options = new ApiOptions
  {
  PageCount = 1,
- PageSize = 2
+ PageSize = 1
  };
 
  var outsideCollaborators = await _gitHub.Organization
  .OutsideCollaborator
  .GetAll(Helper.Organization, OrganizationMembersFilter.All, options);
 
  Assert.NotNull(outsideCollaborators);
- Assert.Equal(2, outsideCollaborators.Count);
+ Assert.Equal(1, outsideCollaborators.Count);
  }
  }
 
- [IntegrationTest(Skip = "It seems this API endpoint does not support pagination as page size/count are not adhered to")]
+ [IntegrationTest]
  public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithAllFilterWithStart()
  {
  var repoName = Helper.MakeNameWithTimestamp("public-repo");
@@ -171,6 +171,7 @@ public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithAllFilterWithStar
 
  Assert.Equal(1, firstPageOfOutsideCollaborators.Count);
  Assert.Equal(1, secondPageOfOutsideCollaborators.Count);
+ Assert.NotEqual(firstPageOfOutsideCollaborators[0].Login, secondPageOfOutsideCollaborators[0].Login);
  }
  }
 
@@ -205,7 +206,7 @@ public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithTwoFactorFilterAn
  var options = new ApiOptions
  {
  PageCount = 1,
- PageSize = 2
+ PageSize = 1
  };
 
  var outsideCollaborators = await _gitHub.Organization

diff --git a/Octokit.Tests.Integration/Reactive/ObservableOrganizationOutsideCollaboratorsClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableOrganizationOutsideCollaboratorsClientTests.cs
@@ -121,18 +121,18 @@ public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithAllFilterAndApiOp
  var options = new ApiOptions
  {
  PageCount = 1,
- PageSize = 2
+ PageSize = 1
  };
 
  var outsideCollaborators = await _client
  .GetAll(Helper.Organization, OrganizationMembersFilter.All, options).ToList();
 
  Assert.NotNull(outsideCollaborators);
- Assert.Equal(2, outsideCollaborators.Count);
+ Assert.Equal(1, outsideCollaborators.Count);
  }
  }
 
- [IntegrationTest(Skip = "It seems this API endpoint does not support pagination as page size/count are not adhered to")]
+ [IntegrationTest]
  public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithAllFilterWithStart()
  {
  var repoName = Helper.MakeNameWithTimestamp("public-repo");
@@ -163,6 +163,7 @@ public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithAllFilterWithStar
 
  Assert.Equal(1, firstPageOfOutsideCollaborators.Count);
  Assert.Equal(1, secondPageOfOutsideCollaborators.Count);
+ Assert.NotEqual(firstPageOfOutsideCollaborators[0].Login, secondPageOfOutsideCollaborators[0].Login);
  }
  }
 
@@ -196,7 +197,7 @@ public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithTwoFactorFilterAn
  var options = new ApiOptions
  {
  PageCount = 1,
- PageSize = 2
+ PageSize = 1
  };
 
  var outsideCollaborators = await _client