Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAllTopics on RepositoryClient is not available in v0.50 #2328

Closed
JustinGol opened this issue May 24, 2021 · 9 comments
Closed

GetAllTopics on RepositoryClient is not available in v0.50 #2328

JustinGol opened this issue May 24, 2021 · 9 comments

Comments

@JustinGol
Copy link

@SeanKilleen, not sure Im missing something but I cant find the new method GetAllTopics on the RepositoryClient. Im using v0.50, double checked and decomplied. I saw in the release the commit for this is included. I can see it in the integration tests too so not sure whats happening. TIA

image
image

Originally posted by @JustinGol in #1707 (comment)

@SeanKilleen
Copy link
Contributor

@JustinGol do you have a code sample that isn't working? Are you using another part of the library with success or is this a new effort? Asking so I can keep that in mind as I look into this. (Not back at a computer yet to check).

@SeanKilleen
Copy link
Contributor

SeanKilleen commented May 25, 2021

Well @JustinGol I have good news and bad news. 😆

The good news is, you're not wrong -- it is indeed in the integration tests and was merged in.

The bad news is, you're not seeing it in the wild because it's not yet been released.

I assumed it would be available by now but there hasn't been an additional release yet. I look forward to seeing it out there as well.

You can subscribe to releases by:

  • Selecting "custom" under Watch:

the notifications dropdown, showing a custom notification option

  • And checking the box for releases:

the custom notifications screen with the releases box checked

CC @shiftkey @ryangribble in case they'd like to take a whack at a release to get it out there. (if I can help, let me know.)

@SeanKilleen
Copy link
Contributor

@JustinGol see my comment above and, if you agree, go ahead and close this issue. Thanks!

@JustinGol
Copy link
Author

When I checked the release commits it was there, so not sure how that ended up like that.
image

image

@JustinGol
Copy link
Author

Well @JustinGol I have good news and bad news. 😆

The good news is, you're not wrong -- it is indeed in the integration tests and was merged in.

The bad news is, you're not seeing it in the wild because it's not yet been released.

I assumed it would be available by now but there hasn't been an additional release yet. I look forward to seeing it out there as well.

You can subscribe to releases by:

  • Selecting "custom" under Watch:

the notifications dropdown, showing a custom notification option

  • And checking the box for releases:

the custom notifications screen with the releases box checked

CC @shiftkey @ryangribble in case they'd like to take a whack at a release to get it out there. (if I can help, let me know.)

@SeanKilleen Thanks for looking into this and for the detailed and quick reply.

@SeanKilleen
Copy link
Contributor

@JustinGol in the view you showed in the screenshot, you were showing all the commits since v0.50.0, because it was comparing against master. I think that's where the confusion came in.

But I'm glad someone else is looking to use the contribution! :)

@JustinGol
Copy link
Author

@JustinGol in the view you showed in the screenshot, you were showing all the commits since v0.50.0, because it was comparing against master. I think that's where the confusion came in.

But I'm glad someone else is looking to use the contribution! :)

It would help if I actually read what came after the 8 commits, sorry for wasting your time. I searched the repo as well as I thought v0.50 had the latest master changes too. @SeanKilleen, appreciate your help with this, very keen to use this feature. I have almost 100 repo's I want to use this for and we want to leverage it for a tool in Slack we built for creating a new repo.

@Brend-Smits
Copy link
Contributor

I actually stumbled on this issue because I thought this was already released. Is there any release planned?

@SeanKilleen
Copy link
Contributor

SeanKilleen commented Jul 16, 2021

I think @shiftkey may have been busy building the future of GitHub for a minute :) and ditto @ryangribble with OctopusDeploy.

Brendan / Ryan, these changes were merged Feb 25th, so just barely missed the Feb 21st release.

Is there a next planned release? Is there any way I could support that endeavor? I'm happy to onboard into that process if you would find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants