Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Add CreatedAt field to WorkflowJob Model #2728

Closed
1 task done
lineville opened this issue Jun 26, 2023 · 6 comments · Fixed by #2729
Closed
1 task done

[FEAT]: Add CreatedAt field to WorkflowJob Model #2728

lineville opened this issue Jun 26, 2023 · 6 comments · Fixed by #2729
Labels
Type: Feature New feature or request

Comments

@lineville
Copy link
Contributor

Describe the need

The current Octokit model for WorkflowJob is missing the CreatedAt field which was recently added to the REST API for listing workflow jobs. I would like to contribute a small PR that adds this field to the model.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lineville lineville added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jun 26, 2023
@kfcampbell kfcampbell added Priority: Normal and removed Status: Triage This is being looked at and prioritized labels Jun 26, 2023
@kfcampbell
Copy link
Member

@lineville I don't see created_at in the docs linked above. Has it been publicly released yet?

@lineville
Copy link
Contributor Author

@kfcampbell so oddly enough they don't show that field in the "Example Response" tab but it is shown in the "Response Schema" and listed as non-nullable. In my testing calling the API directly, it is including the field. I believe this is a somewhat recent addition, at least in the somewhat recent past this property wasn't there, so I'm guessing the docs there are just lagging behind a bit (at least in the response example)

@kfcampbell
Copy link
Member

Interesting! Thanks for the background.

@lineville
Copy link
Contributor Author

@kfcampbell Any plans to cut a release in the near future 😄 ?

@kfcampbell
Copy link
Member

@lineville here you go!

@lineville
Copy link
Contributor Author

@kfcampbell Thanks so much, appreciate the quick turnaround 🙏

@lineville lineville mentioned this issue Jun 28, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants