Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Make WorkflowJob.CreatedAt nullable #2733

Closed
1 task done
lineville opened this issue Jun 28, 2023 · 0 comments · Fixed by #2734
Closed
1 task done

[BUG]: Make WorkflowJob.CreatedAt nullable #2733

lineville opened this issue Jun 28, 2023 · 0 comments · Fixed by #2734
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@lineville
Copy link
Contributor

What happened?

I recently added the CreatedAt field to the WorkflowJob model as a DateTimeOffset type. It came to my attention that this field has only been added to the REST API for dotcom, and GHES 3.9 but not older versions of the GHES rest API. For that reason, this field should be made nullable DateTimeOffset? to avoid incompatibilities with older GHES versions.

Versions

Octokit.net 6.2.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lineville lineville added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jun 28, 2023
@lineville lineville mentioned this issue Jun 28, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make CreatedAt nullable lineville/octokit.net
1 participant
@lineville