Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue Timeline exceptions by adding new EventInfoState values #1563

Merged
merged 6 commits into from
Apr 2, 2017
Merged

Fix Issue Timeline exceptions by adding new EventInfoState values #1563

merged 6 commits into from
Apr 2, 2017

Commits on Mar 11, 2017

  1. Update existing tests to use Octokit PR 1503 as it has some of the ne… 

    …wer event types that are failing to deserialize
    @ryangribble
    ryangribble committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    c89a29f View commit details
    Browse the repository at this point in the history

  2. Write a timeline test that processes the most recent 20 closed PRs an… 

    …d 20 open Issues in octokit.net in attempt to more likely encounter a new EventType enum value added by github api changes
    @ryangribble
    ryangribble committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    7084a39 View commit details
    Browse the repository at this point in the history

  3. Fix failing tests by adding 2 new (undocumented) EventInfoState values

    @ryangribble
    ryangribble committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    3a1e4b8 View commit details
    Browse the repository at this point in the history

  4. Changed test to use microsoft/vscode

    @ryangribble
    ryangribble committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    3c8e5c6 View commit details
    Browse the repository at this point in the history

  5. Found another new event type!

    @ryangribble
    ryangribble committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    31bfc5c View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2017

  1. response enums can be camelcase as underscores are removed in the des… 

    …erializer
    @ryangribble
    ryangribble committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    a936184 View commit details
    Browse the repository at this point in the history