Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Check Suites API #1846

Merged
merged 84 commits into from
Jul 14, 2018
Merged

Implement Check Suites API #1846

merged 84 commits into from
Jul 14, 2018

Commits on May 7, 2018

  1. Check run request models

    @Cyberboss
    Cyberboss committed May 7, 2018
    Configuration menu
    Copy the full SHA
    ae43fc7 View commit details
    Browse the repository at this point in the history

  2. Check Run response models

    @Cyberboss
    Cyberboss committed May 7, 2018
    Configuration menu
    Copy the full SHA
    8ab8d63 View commit details
    Browse the repository at this point in the history

  3. Check run clients

    @Cyberboss
    Cyberboss committed May 7, 2018
    Configuration menu
    Copy the full SHA
    a473b24 View commit details
    Browse the repository at this point in the history

  4. Check run ApiUrls and AcceptHeaders

    @Cyberboss
    Cyberboss committed May 7, 2018
    Configuration menu
    Copy the full SHA
    561d086 View commit details
    Browse the repository at this point in the history

  5. Pack it all together for now

    @Cyberboss
    Cyberboss committed May 7, 2018
    Configuration menu
    Copy the full SHA
    c7704b0 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. Add missing accept headers to connection calls

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    319444d View commit details
    Browse the repository at this point in the history

  2. Standardize class definitions

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    c17c997 View commit details
    Browse the repository at this point in the history

  3. Merge upstream/master into CheckRuns

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    e1512f1 View commit details
    Browse the repository at this point in the history

  4. Standardize function names

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    ef25014 View commit details
    Browse the repository at this point in the history

  5. Merge ICheckRunAnnotationsClient into ICheckRunsClient

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    5530d72 View commit details
    Browse the repository at this point in the history

  6. Properly organize clients

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    ea9d629 View commit details
    Browse the repository at this point in the history

  7. Cleanup CheckRun response model

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    2960e5e View commit details
    Browse the repository at this point in the history

  8. Fix slug check run urls

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    92333d3 View commit details
    Browse the repository at this point in the history

  9. Add checks installation permission

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    f6eeee0 View commit details
    Browse the repository at this point in the history

  10. Use StringEnums where appropriate

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    97b24de View commit details
    Browse the repository at this point in the history

  11. Cleanup check run output models

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    cfa63a8 View commit details
    Browse the repository at this point in the history

  12. Flesh out CheckSuite model

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    70d84bf View commit details
    Browse the repository at this point in the history

  13. Delete CheckRunsList

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    21cf835 View commit details
    Browse the repository at this point in the history

  14. Remove a sealed, fix some line endings

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    f39a637 View commit details
    Browse the repository at this point in the history

  15. Adding check suite models

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    0cac015 View commit details
    Browse the repository at this point in the history

  16. Skeleton check suite client implementation

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    6688ece View commit details
    Browse the repository at this point in the history

  17. Add check suite ApiUrls

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    5b40de8 View commit details
    Browse the repository at this point in the history

  18. Flesh out check suites client

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    f5683fa View commit details
    Browse the repository at this point in the history

  19. Add parameterless CheckRun constructor

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    3534c64 View commit details
    Browse the repository at this point in the history

  20. Add DebuggerDisplay to checks models

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    bd9ceb8 View commit details
    Browse the repository at this point in the history

  21. Add observable checks interfaces

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    e186550 View commit details
    Browse the repository at this point in the history

  22. Add return values to POST and PATCH check clients

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    8a6a59f View commit details
    Browse the repository at this point in the history

  23. Fix some check suite client return values

    @Cyberboss
    Cyberboss committed May 8, 2018
    Configuration menu
    Copy the full SHA
    e58fee9 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2018

  1. Skeleton reactive checks implementation

    @Cyberboss
    Cyberboss committed May 9, 2018
    Configuration menu
    Copy the full SHA
    b71a376 View commit details
    Browse the repository at this point in the history

  2. Implement observable checks clients

    @Cyberboss
    Cyberboss committed May 9, 2018
    Configuration menu
    Copy the full SHA
    b75dced View commit details
    Browse the repository at this point in the history

  3. Remove rogue tabs

    @Cyberboss
    Cyberboss committed May 9, 2018
    Configuration menu
    Copy the full SHA
    86c19a5 View commit details
    Browse the repository at this point in the history

  4. Add CheckSuiteEventPayload

    @Cyberboss
    Cyberboss committed May 9, 2018
    Configuration menu
    Copy the full SHA
    1002e4a View commit details
    Browse the repository at this point in the history

  5. Add CheckRunEventPayload

    @Cyberboss
    Cyberboss committed May 9, 2018
    Configuration menu
    Copy the full SHA
    6176d06 View commit details
    Browse the repository at this point in the history

  6. Add DebuggerDisplay attributes to checks API payloads

    @Cyberboss
    Cyberboss committed May 9, 2018
    Configuration menu
    Copy the full SHA
    03505c9 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. Properly nullables check suite/run conclusion

    @Cyberboss
    Cyberboss committed May 11, 2018
    Configuration menu
    Copy the full SHA
    7d9f6e7 View commit details
    Browse the repository at this point in the history

  2. Add CheckSuiteEventTests

    @Cyberboss
    Cyberboss committed May 11, 2018
    Configuration menu
    Copy the full SHA
    afb682b View commit details
    Browse the repository at this point in the history

  3. Fix checks client accessor naming issues

    @Cyberboss
    Cyberboss committed May 11, 2018
    Configuration menu
    Copy the full SHA
    b90d056 View commit details
    Browse the repository at this point in the history

  4. Add missing Text field to CheckRunOutput

    @Cyberboss
    Cyberboss committed May 11, 2018
    Configuration menu
    Copy the full SHA
    febec72 View commit details
    Browse the repository at this point in the history

  5. Marks CheckRunUpdate's conclusion as nullable

    @Cyberboss
    Cyberboss committed May 11, 2018
    Configuration menu
    Copy the full SHA
    0295807 View commit details
    Browse the repository at this point in the history

  6. Fix reactive checks client naming

    @Cyberboss
    Cyberboss committed May 11, 2018
    Configuration menu
    Copy the full SHA
    9a37903 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. Today I learned DateTimeOffset is a struct 

    Makes CheckRunUpdate's DateTimeOffsets nullable
    @Cyberboss
    Cyberboss committed May 14, 2018
    Configuration menu
    Copy the full SHA
    57d8848 View commit details
    Browse the repository at this point in the history

  2. Modify check clients to put slug version before repo id version

    @Cyberboss
    Cyberboss committed May 14, 2018
    Configuration menu
    Copy the full SHA
    a489ee4 View commit details
    Browse the repository at this point in the history

  3. Add nullable to CheckRun.CompletedAt

    @Cyberboss
    Cyberboss committed May 14, 2018
    Configuration menu
    Copy the full SHA
    42720f8 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2018

  1. Implement parameterless ICheckRunsClient.GetAllForReference and GetAl… 

    …lForCheckSuite
    @Cyberboss
    Cyberboss committed May 15, 2018
    Configuration menu
    Copy the full SHA
    199489c View commit details
    Browse the repository at this point in the history

  2. Add missing RequestParameters base to CheckSuiteRequest

    @Cyberboss
    Cyberboss committed May 15, 2018
    Configuration menu
    Copy the full SHA
    594cfba View commit details
    Browse the repository at this point in the history

  3. Implement checks API GetAll methods

    @Cyberboss
    Cyberboss committed May 15, 2018
    Configuration menu
    Copy the full SHA
    a1d3c7a View commit details
    Browse the repository at this point in the history

  4. Bring parity to Reactive checks clients

    @Cyberboss
    Cyberboss committed May 15, 2018
    Configuration menu
    Copy the full SHA
    b3c1b56 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2018

  1. fix project settings to get GitHubApp helper working again

    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    4390468 View commit details
    Browse the repository at this point in the history

  2. remove un-needed InstallationId setting - provide helper method to fi… 

    …nd installation based on owner
    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    2cbc605 View commit details
    Browse the repository at this point in the history

  3. fix up request object ctors based on required/optional parameters

    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    ceee35e View commit details
    Browse the repository at this point in the history

  4. fix up request object ctors based on required/optional parameters

    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    1f22ffe View commit details
    Browse the repository at this point in the history

  5. add some initial integration tests for CheckSuites and CheckRuns incl… 

    …uding some helper methods
    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    36973a3 View commit details
    Browse the repository at this point in the history

  6. Add test for Request CheckSuite 

    Fix Request CheckSuite to use correct Uri
Fix Request CheckSuite return type as it doesnt return an object
Fix CheckSuiteTriggerRequest ctor to make required fields mandatory
    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    68c291c View commit details
    Browse the repository at this point in the history

  7. simplify Get CheckSuite test to not require as much data setup

    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    c861eec View commit details
    Browse the repository at this point in the history

  8. Add test for CheckSuite GetAllForReference

    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    7430553 View commit details
    Browse the repository at this point in the history

  9. Add test for CheckSuite UpdatePreferences

    @ryangribble
    ryangribble committed May 28, 2018
    Configuration menu
    Copy the full SHA
    d242c3a View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2018

  1. rename response models

    @ryangribble
    ryangribble committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    64f8ac8 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2018

  1. rename CheckSuitesList to CheckSuitesResponse and use as response to … 

    …the GetAll calls
    @ryangribble
    ryangribble committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    0a6176e View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @ryangribble
    ryangribble committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    8aeb805 View commit details
    Browse the repository at this point in the history

  3. Fix observable

    @ryangribble
    ryangribble committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    4321431 View commit details
    Browse the repository at this point in the history

  4. fix model convention tests

    @ryangribble
    ryangribble committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    f28b770 View commit details
    Browse the repository at this point in the history

  5. remove CheckRuns so we can focus only on CheckSuites for now

    @ryangribble
    ryangribble committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    368ad79 View commit details
    Browse the repository at this point in the history

  6. naming things is hard

    @ryangribble
    ryangribble committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    0a98187 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2018

  1. oh so many unit tests for CheckSuites methods

    @ryangribble
    ryangribble committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    aadf84c View commit details
    Browse the repository at this point in the history

  2. make client mockable

    @ryangribble
    ryangribble committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    bb4bf66 View commit details
    Browse the repository at this point in the history

  3. Fix issue with .Max() when no results returned

    @ryangribble
    ryangribble committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    95ce0c1 View commit details
    Browse the repository at this point in the history

  4. fix request parameter names

    @ryangribble
    ryangribble committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    47482b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2018

  1. add Xml doc comments

    @ryangribble
    ryangribble committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    c538f47 View commit details
    Browse the repository at this point in the history

  2. Add XmlDoc comments to request/common model objects

    @ryangribble
    ryangribble committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    02d6ebe View commit details
    Browse the repository at this point in the history

  3. rename class to match usage

    @ryangribble
    ryangribble committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    2a2929c View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into check-suites 

    # Conflicts:
#	Octokit.Tests.Integration/Clients/GitHubAppsClientTests.cs
#	Octokit/Helpers/AcceptHeaders.cs
    @ryangribble
    ryangribble committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    c389a16 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2018

  1. tidy ups

    @ryangribble
    ryangribble committed Jul 8, 2018
    Configuration menu
    Copy the full SHA
    a7a743e View commit details
    Browse the repository at this point in the history

  2. xmldoc for observable clients

    @ryangribble
    ryangribble committed Jul 8, 2018
    Configuration menu
    Copy the full SHA
    7e003d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. fix method order

    @ryangribble
    ryangribble committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    da3f944 View commit details
    Browse the repository at this point in the history

  2. add observable unit tests and get them passing

    @ryangribble
    ryangribble committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    56062d2 View commit details
    Browse the repository at this point in the history

  3. Add Observable unit tests and get them passing

    @ryangribble
    ryangribble committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    b1d3796 View commit details
    Browse the repository at this point in the history

  4. add observable integration tests

    @ryangribble
    ryangribble committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    18b68bf View commit details
    Browse the repository at this point in the history

  5. tidy up ApiUrl method name

    @ryangribble
    ryangribble committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    6b2603a View commit details
    Browse the repository at this point in the history

  6. whitespace/using tidy ups

    @ryangribble
    ryangribble committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    87b5b43 View commit details
    Browse the repository at this point in the history

  7. Ensure CheckSuiteEventPayload class is handled in deserializer and ad… 

    …d to activity test
    @ryangribble
    ryangribble committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    21e95a1 View commit details
    Browse the repository at this point in the history

  8. add response model XmlDoc comments

    @ryangribble
    ryangribble committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    145c329 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. missed one xmldoc

    @ryangribble
    ryangribble committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    dadc3ce View commit details
    Browse the repository at this point in the history

  2. add xmldoc to NewCheckSuite request and remove HeadBranch property as… 

    … it doesnt exist anymore
    @ryangribble
    ryangribble committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    d36e201 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. add some extra check suites integration tests

    @ryangribble
    ryangribble committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    bdb1c23 View commit details
    Browse the repository at this point in the history