Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement changes to Checks API for Annotations models and re-request endpoint #1857

Merged
merged 7 commits into from
Sep 3, 2018
Merged

Implement changes to Checks API for Annotations models and re-request endpoint #1857

merged 7 commits into from
Sep 3, 2018

Commits on Aug 23, 2018

  1. Attempt to handle both old and new annotations models so we support t… 

    …he changes on github.com as well as still support GHE2.14

add Path and AnnotationLevel fields
flag Filename and WarningLevel as deprecated/obsolete
also flag BlobHref as deprecated on NewCheckRunAnnotation
Adjust ctors to handle new and legacy field options
    @ryangribble
    ryangribble committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    e432ca8 View commit details
    Browse the repository at this point in the history

  2. adjust tests to remove use of obsoleted fields

    @ryangribble
    ryangribble committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    d50f5d4 View commit details
    Browse the repository at this point in the history

  3. fix a couple of other tests using unrelated obsoleted fields

    @ryangribble
    ryangribble committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    a99df42 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2018

  1. Mark check suite Request method and request object as obsolete

    @ryangribble
    ryangribble committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    51a3914 View commit details
    Browse the repository at this point in the history

  2. Add Rerequest() method to normal and observable clients 

    Add unit and integration tests
    @ryangribble
    ryangribble committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    4baede9 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2018

  1. add StartColumn and EndColumn as optional fields for CheckRunAnnotati… 

    …on response and NewCheckRunAnnotation request
    @ryangribble
    ryangribble committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    0488b47 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2018

  1. remove integration tests for Request() method as they no longer work … 

    …on github.com anyway
    @ryangribble
    ryangribble committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    16feded View commit details
    Browse the repository at this point in the history