Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Approved] Add repository topics #2246

Merged
merged 56 commits into from
Feb 25, 2021
Merged

[Approved] Add repository topics #2246

merged 56 commits into from
Feb 25, 2021

Commits on Sep 8, 2020

  1. ReSharper auto migration

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    220e9a3 View commit details
    Browse the repository at this point in the history

  2. Add read-ony list of topics to repository class

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1d0cb56 View commit details
    Browse the repository at this point in the history

  3. Switch to IReadOnlyList<> for immutability 

    Guided by tests. Thanks, Octokit tests!
    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    3fa7807 View commit details
    Browse the repository at this point in the history

  4. Add mercy preview to clients returning Task<Repository>

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    56295b3 View commit details
    Browse the repository at this point in the history

  5. get all topics method

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    21d3bbd View commit details
    Browse the repository at this point in the history

  6. ReplaceAllTopics method

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4b3e57f View commit details
    Browse the repository at this point in the history

  7. Add fields to search request

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    697d3d6 View commit details
    Browse the repository at this point in the history

  8. Add parameter qualifiers

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    efd373e View commit details
    Browse the repository at this point in the history

  9. Correct my misunderstanding of what Topics represents

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    620cb26 View commit details
    Browse the repository at this point in the history

  10. Add preview header to AcceptHeaders

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    dd518d3 View commit details
    Browse the repository at this point in the history

  11. Add headers

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    091bff0 View commit details
    Browse the repository at this point in the history

  12. overloads for repository ID

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    cb5a06c View commit details
    Browse the repository at this point in the history

  13. Update the interface

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4a178ea View commit details
    Browse the repository at this point in the history

  14. Convert to use ApiOptions

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    af48670 View commit details
    Browse the repository at this point in the history

  15. add overloads

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    e68a5b8 View commit details
    Browse the repository at this point in the history

  16. Observable for GetAllTopics

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    ad9b819 View commit details
    Browse the repository at this point in the history

  17. observable implementations for ReplaceAllTopics

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    52db2ab View commit details
    Browse the repository at this point in the history

  18. Use IObservable<string>

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    fca13f4 View commit details
    Browse the repository at this point in the history

  19. Ah, I see -- need to sync up the signatures.

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0b88b7a View commit details
    Browse the repository at this point in the history

  20. Is this the only way to make the signatures match up?

    @SeanKilleen
    SeanKilleen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1cd3116 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Some integration tests 

    Using my repo for now as the Octokit one doesn't have topics
    @SeanKilleen
    SeanKilleen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    456f431 View commit details
    Browse the repository at this point in the history

  2. Add RepositoryTopics from octokit#1721

    @SeanKilleen
    SeanKilleen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    ebbe318 View commit details
    Browse the repository at this point in the history

  3. Use RepositoryTopics class

    @SeanKilleen
    SeanKilleen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    7d8d0d7 View commit details
    Browse the repository at this point in the history

  4. More signature updates

    @SeanKilleen
    SeanKilleen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    95f102a View commit details
    Browse the repository at this point in the history

  5. Add ReplaceAllTopics test real quick

    @SeanKilleen
    SeanKilleen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    67998dc View commit details
    Browse the repository at this point in the history

  6. Empty list by default

    @SeanKilleen
    SeanKilleen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    ca9e8e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. integration test updates

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    7761dbd View commit details
    Browse the repository at this point in the history

  2. Additional tests for using repo ID

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    9b126e5 View commit details
    Browse the repository at this point in the history

  3. Some unit tests & corresponding changes

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    1e7ac1d View commit details
    Browse the repository at this point in the history

  4. unit tests for the GetAllTopics method

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    1792546 View commit details
    Browse the repository at this point in the history

  5. Unit tests, including a failing one I don't understand

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    fd7a2be View commit details
    Browse the repository at this point in the history

  6. extract client & connection to fields

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    0d6da2a View commit details
    Browse the repository at this point in the history

  7. oops, bad argumnt

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    327ee27 View commit details
    Browse the repository at this point in the history

  8. RepositoryTopics unit tests

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    c9ed7a7 View commit details
    Browse the repository at this point in the history

  9. Mark integration tests as such

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    19ea9fd View commit details
    Browse the repository at this point in the history

  10. Integreation tests for search

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    27d4d68 View commit details
    Browse the repository at this point in the history

  11. Some failing tests to fix soon

    @SeanKilleen
    SeanKilleen committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    6068b1b View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. more unit tests

    @SeanKilleen
    SeanKilleen committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    fe182e1 View commit details
    Browse the repository at this point in the history

  2. Update Octokit.Reactive/Clients/IObservableRepositoriesClient.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    b7c6901 View commit details
    Browse the repository at this point in the history

  3. Update Octokit.Tests.Integration/Clients/SearchClientTests.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    5dba2fd View commit details
    Browse the repository at this point in the history

  4. Update Octokit.Tests.Integration/Clients/SearchClientTests.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    e55273b View commit details
    Browse the repository at this point in the history

  5. Update Octokit/Clients/IRepositoriesClient.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    30b2215 View commit details
    Browse the repository at this point in the history

  6. Update Octokit/Clients/IRepositoriesClient.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    cd0f082 View commit details
    Browse the repository at this point in the history

  7. Update Octokit.Tests/Clients/SearchClientTests.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    cdbb96b View commit details
    Browse the repository at this point in the history

  8. Update Octokit/Clients/RepositoriesClient.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    550f4e3 View commit details
    Browse the repository at this point in the history

  9. Update Octokit/Helpers/ApiUrls.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    3e10bc2 View commit details
    Browse the repository at this point in the history

  10. Update Octokit/Clients/RepositoriesClient.cs

    @SeanKilleen
    SeanKilleen authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    a6c49ed View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Merge branch 'main' into 1707_add-repository-topics

    @SeanKilleen
    SeanKilleen authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    04161cf View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Merge branch 'main' into 1707_add-repository-topics

    @shiftkey
    shiftkey authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    4b62ec0 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Use helpers and CreateRepositoryContext

    @SeanKilleen
    SeanKilleen committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    257be14 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 1707_add-repository-topics

    @SeanKilleen
    SeanKilleen authored Feb 22, 2021
    Configuration menu
    Copy the full SHA
    5fb88ad View commit details
    Browse the repository at this point in the history

  3. cleanup: explicit private modifier

    @SeanKilleen
    SeanKilleen committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    8730206 View commit details
    Browse the repository at this point in the history

  4. cleanup: field names

    @SeanKilleen
    SeanKilleen committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    84d6144 View commit details
    Browse the repository at this point in the history

  5. cleanup: extract variable

    @SeanKilleen
    SeanKilleen committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    fa94465 View commit details
    Browse the repository at this point in the history

  6. cleanup: spacing

    @SeanKilleen
    SeanKilleen committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c5574ed View commit details
    Browse the repository at this point in the history

  7. Cleanup: usings

    @SeanKilleen
    SeanKilleen committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    2bc3df5 View commit details
    Browse the repository at this point in the history