Move the build to .net 5 #2294
Merged
Move the build to .net 5 #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2294 +/- ##
==========================================
+ Coverage 65.88% 65.91% +0.02%
==========================================
Files 553 553
Lines 14463 14465 +2
Branches 846 846
==========================================
+ Hits 9529 9534 +5
+ Misses 4775 4772 -3
Partials 159 159
|
|
The failures seem to be the same failures in #2293, so it looks like using .net 5 for the build is fine. This fixes the broken AppVeyor build. |
.NET 5 is fine for building projects that target older versions of .NET. This also should fix the AppVeyor build which fails because the latest `coverlet.console` only supports .NET 5.
shiftkey
force-pushed
the
use-dotnet-5
branch
from
b073425
to
dd78673
Compare
|
release_notes: Now using .NET 5 to build and publish |
nickfloyd
added
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 5 is fine for building projects that target older versions of .NET. This also should fix the AppVeyor build which fails because the latest
coverlet.consoleonly supports .NET 5.