-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for the Device Flow Oauth authentication pattern #2310
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2310 +/- ##
=======================================
Coverage 65.99% 65.99%
=======================================
Files 554 554
Lines 14519 14519
Branches 857 857
=======================================
Hits 9582 9582
Misses 4779 4779
Partials 158 158
|
This failure looks unrelated to my change, possibly just an infrastructure hiccup? Can it be re-run? |
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palenshus This is a great addition, thank you for taking the time to do it!
I just had a few comments on how you've set up some of the class property's accessibility. I was wondering, were you favoring protected
over private
because it's the dominant pattern for most of the models in Octokit.net? It seems that most of those now implement ctors
in one form or another so that makes it where I think we could change most of the protected
access modifiers to the more appropriate private
ones.
I didn't see where we needed to use the class as a derived class but I could've just missed something. Let me know your thoughts on the suggestions when you get the chance.
Thanks again for putting in the effort here - it is sincerely appreciated and will result in something that will help our community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we are almost there. 3 properties need to have their setters made private and I think we'll be good to go. Thanks again for putting in the work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
Thanks Nick, it's been a long road, I'm so glad to have this in now! |
release_notes: Adds support for the Device Flow Oauth authentication pattern |
Adds support for the Device flow authentication pattern: https://docs.github.com/en/developers/apps/authorizing-oauth-apps#device-flow
Resolves #2308
Usage: