fix: links into github documentation #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was just curious to know about that `ProductHeaderValue` type and found references in this file. However the links were not 404's but also not what was originally intended. I didn't check the whole file, just these two URLs.
Roma133
referenced
this pull request
Dec 5, 2021
We plan to release this code under the MIT license so might as well get the right things in place early.
nickfloyd
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Thanks for doing this! ❤️ You're right in assuming that there is more to change. I am going to make an up-for-grabs issue to see if we can get the others updated - hopefully, once we automate things like model generation then these types of things will not get so far out of date.
|
followup: #2474 |
|
release_notes: Fixes links to github API documentation |
nickfloyd
added
Type: Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just curious to know about that
ProductHeaderValuetype and found references in this file. However the links were not 404's but also not what was originally intended. I didn't check the whole file, just these two URLs.